Skip to content

Require array access index arguments to be given in order#27

Merged
johnstairs merged 1 commit intomainfrom
johnstairs/array-index-access-dimension-ordering
Dec 8, 2022
Merged

Require array access index arguments to be given in order#27
johnstairs merged 1 commit intomainfrom
johnstairs/array-index-access-dimension-ordering

Conversation

@johnstairs
Copy link
Copy Markdown
Member

Based on feedback, we now require array access index arguments to be given in the correct order, even when dimension names are used.

For example, this would no longer be valid:

MyRec: !record
  fields:
    arrayField: !array
        items: int
        dimensions: [x, y]
  computedFields:
    accessArrayElementByName: arrayField[y:1, x:0]

Note that the x and y arguments are provided out of order. You will now have to write arrayField[x:0, y:1]

Addresses #20

@johnstairs johnstairs requested a review from hansenms December 6, 2022 14:57
@johnstairs johnstairs merged commit c7d7354 into main Dec 8, 2022
@johnstairs johnstairs deleted the johnstairs/array-index-access-dimension-ordering branch December 8, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants