Merged
Conversation
hansenms
approved these changes
Dec 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cases in a union type are all required to be distinct. We were failing to catch cases where types were aliased and therefore the union should be invalid, e.g.:
Secondly, we were missing validation where the type arguments given to a union made up of generic type parameters results in an invalid union, e.g.:
We now surface an error at the location of the union, with locations where the type arguments are provided.
We were also not catching a union made up of
sizeandunit64types, which are equivalent types.Finally, we're changing the representation of the
sizetype in C++ beyardl::Size, an alias ofsize_tif it is 64-bit, otherwiseuint64_t.Addresses #25