Android custom file updates #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 27, 2017 14:02
Prevents developer from having to manually overwrite: - DriveItemRequestBuilder - IDriveItemReqestBuilder - ThumbnailSetRequestBuilder - IThumbnailSetRequestBuilder
Fixes manual addition of custom import statement for: - UploadSession
Fixes manual copying of files: - ChunkedUploadRequest - ChunkedUploadResult
Fixes manual editing of methods: - BaseOnenotePageCollectionRequest - IBaseOnenotePageCollectionRequest - BaseOnenotePageRequest - IBaseOnenotePageRequest
Author
|
There are also two files (ChunkedUploadRequest and ChunkedUploadResult) that need to be generated verbatim each time the generator is run. They are not described by the metadata. |
LouMM
approved these changes
Aug 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently a list of files we manually track when we regenerate the Android SDK that have to be hand-merged. Moving this code into the generator allows us to automate this process.
I have added methods for adding import statements, methods, and overwriting code. These are currently only implemented on the templates that require them.
Each of these methods takes advantage of CodeHelper classes that define the update contents to be made to each file, in accordance with the field's name. This allows us to "automagically" iterate through and apply rules to templates without hardcoding which templates to use in the BaseModel template file.