Skip to content

Conversation

@ramsessanchez
Copy link
Contributor

@ramsessanchez ramsessanchez commented Nov 30, 2021

Build Using microsoftgraph/MSGraph-SDK-Code-Generator#645 as generation. Uses latest metadata.

Microsoft Reviewers: Open in CodeFlow

@ramsessanchez
Copy link
Contributor Author

ramsessanchez commented Nov 30, 2021

@baywet
Copy link
Member

baywet commented Nov 30, 2021

@ramsessanchez this PR mixes 3 weeks of changes with beta + your fix with makes it hard to evaluate the fix. Could you:

  1. queue a generation with current metadata, without the fix. (this won't build, it's expected)
  2. queue a generation with the branch from step 1 as the resource, with the fix.
  3. open a PR from branch of step 2 to branch of step 1

This way, in the PR opened in step 3, we should be able to see the changes of the fix only.

Also, can you queue a generation for v1 with the fix, to see if we have any impact on v1 please?

(and leave this PR open, this is the one we'll end-up merging if everything checks-out)

@ramsessanchez
Copy link
Contributor Author

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for putting those review PRs together. Everything looks good in terms of impact of the change. Let's roll!

@baywet baywet merged commit 0b044f5 into dev Nov 30, 2021
@baywet baywet deleted the beta/pipelinebuild/60231 branch November 30, 2021 21:56
@baywet
Copy link
Member

baywet commented Nov 30, 2021

@ramsessanchez I might have merged too fast, can you put a PR together for the changelog please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants