Skip to content

chore: capture initial branch policy settings#599

Merged
ramsessanchez merged 1 commit intodevfrom
branchprotectionpolicy
Jun 10, 2023
Merged

chore: capture initial branch policy settings#599
ramsessanchez merged 1 commit intodevfrom
branchprotectionpolicy

Conversation

@MIchaelMainer
Copy link
Copy Markdown
Collaborator

@MIchaelMainer MIchaelMainer commented Jun 9, 2023

Capture current policy state so that we can make versioned changes to branch protection policies. This will enable policy history, auditing, review, standardization, and templatization. We will update policy in later PR.

We can ignore the rule that states: At least one value under RequiredStatusChecks must be specified when RequiresStrictStatusChecks is true. This is getting removed

This branch protection policy will not take effect until https://github.com/microsoftgraph/.github/blob/main/policies/branch-protection-sdks.yml has been removed.

Microsoft Reviewers: Open in CodeFlow

Capture current policy state so that we can make versioned changes to branch protection policies. This will enable policy history, auditing, review, standardization, and templatization. We will update policy in later PR.

We can ignore the rule that states: `At least one value under RequiredStatusChecks must be specified when RequiresStrictStatusChecks is true.` This is getting removed
* https://github.com/microsoft/GitOps.Branches/pull/73
* https://github.com/microsoft/GitOps.Branches/issues/72

This branch protection policy will not take effect until https://github.com/microsoftgraph/.github/blob/main/policies/branch-protection-sdks.yml has been removed.
@MIchaelMainer MIchaelMainer requested a review from a team as a code owner June 9, 2023 22:50
@ramsessanchez ramsessanchez merged commit f3a3aeb into dev Jun 10, 2023
@ramsessanchez ramsessanchez deleted the branchprotectionpolicy branch June 10, 2023 00:01
@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

2 invalid rules

  • RequiresStrictStatusChecks must be true when specifying RequiredStatusChecks.
  • RequiresStrictStatusChecks must be true when specifying RequiredStatusChecks.

Total execution time: 0.12 seconds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants