FY2019Q4 Quarterly refresh #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
andrewconnell
commented
May 24, 2019
andrewconnell
commented
- Updated all packages to "wanted" versions
- Fixed screen capture for app registration
- Fixed app registration information in PPTX
- Added key for proper react rendering of array
- Updated code to support MSAL 1.0.0 GA release
Updated all packages to "latest" versions Fixed screen capture for app registration Fixed app registration information in PPTX Added key for proper react rendering of array Updated code to support MSAL 1.0.0 GA release
Updated all packages to "latest" versions Fixed screen capture for app registration Fixed app registration information in PPTX Added key for proper react rendering of array Updated code to support MSAL 1.0.0 GA release
…aph-training-reactspa
jasonjoh
approved these changes
May 29, 2019
| "dependencies": { | ||
| "@fortawesome/fontawesome-free": "^5.7.2", | ||
| "@microsoft/microsoft-graph-client": "^1.5.2", | ||
| "@fortawesome/fontawesome-free": "^5.8.2", |
Member
There was a problem hiding this comment.
Note for future updates: Updates to packages should be reflected in create-app.md (where it tells you to install specific versions)
| "react-scripts": "2.1.5", | ||
| "reactstrap": "^7.1.0" | ||
| "msal": "^1.0.0", | ||
| "react": "^16.8.6", |
Member
There was a problem hiding this comment.
Because this app is created by create-react-app, we need to be cautious updating these libraries. I'm going to update create-react-app to the latest and see what it outputs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.