This repository was archived by the owner on Oct 5, 2023. It is now read-only.
Yaml merge#152
Merged
andrueastman merged 5 commits intomicrosoftgraph:devfrom May 6, 2021
jasonjoh:yaml-merge
Merged
Conversation
Syncing with upstream
- Moved YAML processing into the `YamlHeader` class and simplified code in `RepositoriesService` around using the header. - YAML will now be read from 3 places (if present): README, repo-name.yml, and devx.yml and combined. In case the same setting is present in more than one of these places, values are overwritten with devx.yml taking precedence over repo-name.yml taking precedence over README
baywet
suggested changes
May 2, 2021
SamplesDashboard/SamplesDashboard/Services/RepositoriesService.cs
Outdated
Show resolved
Hide resolved
SamplesDashboard/SamplesDashboard/Services/RepositoriesService.cs
Outdated
Show resolved
Hide resolved
SamplesDashboard/SamplesDashboard/Services/RepositoriesService.cs
Outdated
Show resolved
Hide resolved
SamplesDashboard/SamplesDashboardTests/MessageHandlers/StringContentHandler.cs
Show resolved
Hide resolved
SamplesDashboard/SamplesDashboardTests/MessageHandlers/StringContentHandler.cs
Outdated
Show resolved
Hide resolved
andrueastman
reviewed
May 4, 2021
andrueastman
approved these changes
May 4, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
YamlHeaderclass and simplified code inRepositoriesServicearound using the header.Type of change
Testing