Skip to content
This repository was archived by the owner on Oct 5, 2023. It is now read-only.

Dashboard V2#417

Merged
jasonjoh merged 8 commits intodevfrom
v2
Sep 14, 2021
Merged

Dashboard V2#417
jasonjoh merged 8 commits intodevfrom
v2

Conversation

@jasonjoh
Copy link
Member

@jasonjoh jasonjoh commented Aug 30, 2021

Recreated pull request #405 that was merged inadvertently and subsequently reverted.

This is a complete rewrite of the dashboard.

Reasoning

  1. Constant deluge of Dependabot PR's due to age of React front-end. Due to time/resource scarcity, testing and validating these PR's was not an easy task.
  2. React front-end was using an old, deprecated auth library, oidc-connect. No longer maintained on GitHub, project is archived.
  3. Backend was using outdated versions of the ASP.NET Core auth middleware.

Improvements

  1. Updated the auth stack to use msal-react and Microsoft.Identity.Web.
  2. Recreated FE app, updating all NPM dependencies possible.
  3. Simplified and cleaned up models. There was a lot of duplicated information, mix of conventions, multiple classes in a single file, etc.
  4. Increased code re-use in React app by creating more reusable components.
  5. Visual improvements (tweak to dark mode, user photo via Graph)

Copy link
Contributor

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for cleaning this up 👍🏼

@jasonjoh
Copy link
Member Author

@andrueastman @MaggieKimani1 @thewahome Does this need further review or should we proceed with merging?

@jasonjoh jasonjoh merged commit 901327f into dev Sep 14, 2021
@jasonjoh jasonjoh deleted the v2 branch September 14, 2021 17:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants