Fix processing of RecurrenceRange#13
Fix processing of RecurrenceRange#13peternied merged 18 commits intomicrosoftgraph:masterfrom iambmelt:recurrence
Conversation
Adding new Serializer for Date objects Adding new pkg for models
|
Hi @iambmelt, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
|
|
||
| import com.microsoft.graph.model.Date; | ||
|
|
||
| public class DateSerializerTest extends AndroidTestCase { |
There was a problem hiding this comment.
Could you create a ReocurranceRange and make sure it can be serialized and deserialized with the expected output?
|
|
||
| // validate our split datestring | ||
| if (dateInfo.length != 3) { | ||
| throw new ParseException("Datestring input didn't match format 'yyyy-mm-dd'", 0); |
There was a problem hiding this comment.
Does the index used here for the ParseException matter? I'm not clear on what value makes sense to use
There was a problem hiding this comment.
Its mean to a helpful hint to developers, instead of trying to figure out the index, include the dateStr in the message so it is easy to side by side it.
| * | ||
| * @param dateStr date string of the form <code>yyyy-mm-dd</code> | ||
| */ | ||
| public DateOnly(String dateStr) throws ParseException { |
There was a problem hiding this comment.
sorry I missed this before, Make this a static function, public DateOnly Parse(String ...) throws ParseException {..}, that returns a DateOnly instance. We shouldn't be parsing and throwing exceptions in a ctor
Fixing a number of check style issues
Fixing CheckStyle issues
| @@ -25,13 +18,13 @@ | |||
| */ | |||
| public class BaseRecurrenceRange implements IJsonBackedObject { | |||
There was a problem hiding this comment.
This file has a number of changes that do not look like they are from the code generation library, could you update this file with that output?
3 participants
@peternied note this change also ups gradle to
2.0.0, and the gradlewrapper from2.8-allto2.10-allThis PR includes changes to auto-generated file
BaseRecurrenceRange.java