This repository was archived by the owner on Sep 4, 2020. It is now read-only.
Don't prepend reserved enums with msgraph#68
Merged
caitlinrussell merged 1 commit intomasterfrom Oct 20, 2017
Merged
Conversation
Changing this value to uppercase resolves the conflict but allows the JSON to pass over the wire correctly
Contributor
|
Do we know whether the serializer understood that prepended msgraph_ was to be dropped? Also, are we confident that all services take enums names without regard to case sensitivity? I think we need to ask that question. |
MIchaelMainer
approved these changes
Oct 20, 2017
Contributor
MIchaelMainer
left a comment
MIchaelMainer
left a comment
There was a problem hiding this comment.
Since it looks like Graph is case-insensitive for enums, we can use this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing this value to uppercase resolves the conflict but allows the JSON to pass over the wire correctly