Fixes regression on passing custom baseurl#1614
Merged
Merged
Conversation
andrueastman
requested review from
MIchaelMainer,
baywet,
ddyett,
nikithauc and
zengin
as code owners
baywet
approved these changes
Jan 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #1613
It addresses a regression introduced by adding the baseurl to the
PathParameterscollection of the GraphServiceClient that prevented the correct propagation of custom base urls passed to the constructor.This PR therefore ensures the
RequestAdapteris properly initialized with the custom base url to ensure the correct url is passed to the PathParameters collection.Microsoft Reviewers: Open in CodeFlow