Skip to content

Conversation

@ramsessanchez
Copy link
Contributor

@ramsessanchez ramsessanchez commented Aug 4, 2021

Changes proposed in this pull request

-Adding the maven preview and release stages to buildAndPackage.yml as well as the github release stage.
-Added stage based folders to organize the templates necessary for each stage.
-The github connection in templates/github-release-stage/version-and-release.yml is currently 'ramsessanchez', this will likely need to change.
-Requesting feedback as to what this should be changed to in order to work with the AzureDevOps graph client tooling org.

Other links

@ramsessanchez ramsessanchez changed the title added the maven preview and release stages to buildAndPackage.yml as … Updating build-and-package.yml to include all Stages Aug 4, 2021
@baywet baywet added this to the 2.1.0 milestone Aug 4, 2021
@baywet baywet linked an issue Aug 4, 2021 that may be closed by this pull request
6 tasks
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for putting this together. Great first draft. A few comments to get things finalized.

@baywet baywet modified the milestones: 2.1.0, 2.0.9 Aug 4, 2021
@ramsessanchez ramsessanchez requested a review from baywet August 5, 2021 20:04
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there, thanks for taking in the previous suggestions, a few left.

@baywet baywet mentioned this pull request Aug 6, 2021
@ramsessanchez ramsessanchez requested a review from baywet August 10, 2021 22:24
@ramsessanchez
Copy link
Contributor Author

Another consideration: Making the job within Maven-Preview a deployment job, this would implicitly call download-artifacts and thus remove the need for the file 'templates/download-artifacts.yml'. This would also track history of the Maven-Preview job on the selected environment. Would this be a path to follow?

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for making the last round of updates, a few minor comments left

@ramsessanchez ramsessanchez requested a review from baywet August 13, 2021 21:23
baywet
baywet previously approved these changes Aug 16, 2021
@baywet baywet merged commit 9a80e07 into dev Aug 16, 2021
@baywet baywet deleted the rsh/deploymentStagesYml branch August 16, 2021 19:55
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

95.0% 95.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

migrate to the microsoft graph ADO org

3 participants