graphServiceClient.users(userId).photo().getContent().buildRequest().put(imageBytes) throws java.lang.ClassCastException

[Krisoblucki-okta]

Expected behavior

graphServiceClient.users(userId).photo().getContent().buildRequest().put(imageBytes) should not throw an invalid cast exception from BufferedInputStream to ProfilePhoto

Actual behavior

java.lang.ClassCastException: java.io.BufferedInputStream cannot be cast to com.microsoft.graph.models.extensions.ProfilePhoto

Steps to reproduce the behavior

graphServiceClient.users(userId).photo().getContent().buildRequest().put(imageBytes)

[Krisoblucki-okta]

What is the path for a fix to something like this which doesn't fit into the extensions? I submitted a PR to what the fix could be. I realize that's not how it works due to the change uptake mechanism.

[deepak2016]

@Krisoblucki-okta thanks for reporting your issue, wanted to understand what scenario you are trying to achieve?

[Krisoblucki-okta]

I'm trying to do a straight forward profile photo update

[deepak2016]

bug id: #958277

[Krisoblucki-okta]

@deepak2016 since this is still open, I'm assuming that the issue hasn't been addressed?

[Drakonhawk]

The bug still exists in 1.7.1 release, when you try to set a phone on a contact.
graphServiceClient.me().contacts(contactId).photo().content().buildRequest().put(pictureContent)

[tiagodiogo]

I recently encountered this bug, from my investigation I belive the problem is that the response is a no content with text/plain?
this causes a problem on the httpprovider since everything that is not text/json is assumed to be binary. my fix was:

final String contentType = headers.get(Constants.CONTENT_TYPE_HEADER_NAME);
                if (contentType.contains(Constants.JSON_CONTENT_TYPE)) {
                    logger.logDebug("Response json");
                    return handleJsonResponse(in, getResponseHeadersAsMapOfStringList(response), resultClass);
                } else {
                    logger.logDebug("Response binary");
                    // start hack
                    // https://github.com/microsoftgraph/msgraph-sdk-java/issues/176
                    try{
                        in = checkStreamIsNotEmpty(in);
                    } catch (EmptyInputStreamException ex) {
                        logger.logDebug("Binary response with empty stream");
                        return handleEmptyResponse(getResponseHeadersAsMapOfStringList(response), resultClass);
                    }
                    // finish hack
                    isBinaryStreamInput = true;
                    //no inspection unchecked
                    return (Result) handleBinaryStream(in);
                }

private InputStream checkStreamIsNotEmpty(InputStream inputStream) throws IOException, EmptyInputStreamException {
        PushbackInputStream pushbackInputStream = new PushbackInputStream(inputStream);
        int b;
        b = pushbackInputStream.read();
        if ( b == -1 ) {
            throw new EmptyInputStreamException("No byte can be read from stream " + inputStream);
        }
        pushbackInputStream.unread(b);
        return pushbackInputStream;
    }

private static class EmptyInputStreamException extends RuntimeException {
        public EmptyInputStreamException(String message) {
            super(message);
        }
    }