Gradle 6.x isn't able to pick right Guava variant

[GeertZijlmans1]

Expected behavior

That my application builds fine

Actual behavior

Building app runs into a failure
It complains that it could not resolve the guava library required by the Graph SDK v6.3.0:

Could not resolve com.google.guava:guava:33.0.0-jre.
Required by:
project :ourapp > com.microsoft.graph:microsoft-graph:6.3.0

Trough transitive dependency it will complain that it is unable to select the correct variant for Guava:

Failed to build and package the app, because:
AmbiguousConfigurationSelectionException: Cannot choose between the following variants of com.google.guava:guava:33.0.0-jre:

• androidRuntimeElements
• jreRuntimeElements
  All of them match the consumer attributes:
• Variant 'androidRuntimeElements' capabilities com.google.collections:google-collections:33.0.0-jre and com.google.guava:guava:33.0.0-jre:
  • Unmatched attributes:
    • Provides org.gradle.category 'library' but the consumer didn't ask for it
    • Provides org.gradle.dependency.bundling 'external' but the consumer didn't ask for it
    • Provides org.gradle.jvm.environment 'android' but the consumer didn't ask for it
    • Provides org.gradle.jvm.version '8' but the consumer didn't ask for it
    • Provides org.gradle.libraryelements 'jar' but the consumer didn't ask for it
    • Provides org.gradle.status 'release' but the consumer didn't ask for it
    • Provides org.gradle.usage 'java-runtime' but the consumer didn't ask for it
• Variant 'jreRuntimeElements' capabilities com.google.collections:google-collections:33.0.0-jre and com.google.guava:guava:33.0.0-jre:
  • Unmatched attributes:
    • Provides org.gradle.category 'library' but the consumer didn't ask for it
    • Provides org.gradle.dependency.bundling 'external' but the consumer didn't ask for it
    • Provides org.gradle.jvm.environment 'standard-jvm' but the consumer didn't ask for it
    • Provides org.gradle.jvm.version '8' but the consumer didn't ask for it
    • Provides org.gradle.libraryelements 'jar' but the consumer didn't ask for it
    • Provides org.gradle.status 'release' but the consumer didn't ask for it
    • Provides org.gradle.usage 'java-runtime' but the consumer didn't ask for it

Steps to reproduce the behavior

• Install Gradle 6.x (e.g. 6.8.3)
• Create an application and add the Graph SDK v6.3.0 as a dependency.

[baywet]

Thanks for reporting this. I think this is a miss on our side. One of the benefits of this newer version is that it doesn't depend on guava, and the dependency should have been removed (probably a bad merge at some point)

Here are the places it needs to be removed

• msgraph-sdk-java/gradle/dependencies.gradle

  Line 2 in 0b01ad5

  implementation 'com.google.guava:guava:33.0.0-jre'

• msgraph-sdk-java/pom.xml

  Line 22 in 0b01ad5

  <artifactId>guava</artifactId>

• msgraph-sdk-java/README.md

  Line 25 in 0b01ad5

  //implementation 'com.google.guava:guava:30.1.1-android'

• https://github.com/microsoftgraph/msgraph-sdk-java-core/blob/5e0137b10100ad769386bfaa2fc551afb0c233c5/pom.xml#L26

Would you be willing to submit pull requests to address this?

[GeertZijlmans1]

@baywet Do I understand you correctly that I need to make these changes to the SDK? And create a pull request for you to review and merge?

[baywet]

Correct

[GeertZijlmans1]

@baywet I don't have write access and therefore cannot publish my local branch.

[baywet]

@GeertZijlmans1 fork the repository first, add this new origin to your local repository, and push that branch to your fork instead :)

[GeertZijlmans1]

@baywet Will do that :) instead ... just figuring out your development process

[baywet]

This is a skill you'll use for years to come as forking and submitting a pull request is a coming practice across open source development.

[GeertZijlmans1]

Right. That said I've created two Pull Requests:

• Issue-1860: Remove dependency on Google Guava #1869
• Issue-1860: Remove Google Guava dependency msgraph-sdk-java-core#1530