Skip to content

Configure connection timeout #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
deepak2016 merged 1 commit into from
Feb 4, 2019
Merged

Configure connection timeout #216

deepak2016 merged 1 commit into from
Feb 4, 2019

Conversation

@NakulSabharwal
Copy link
Contributor

@NakulSabharwal NakulSabharwal commented Feb 1, 2019

Fixes #196

Changes proposed in this pull request

  • Added DefaultConnectionConfig which implement IConnectionConfig. Any class implementing IConnectionConfig can be passed with configured timeout values.
  • Added setter and getter functions for changing values timeout values in DefaultHttpProvider.

@deepak2016 deepak2016 merged commit 541a8a2 into dev Feb 4, 2019
@deepak2016 deepak2016 mentioned this pull request Feb 5, 2019
Closed
@NakulSabharwal NakulSabharwal mentioned this pull request Mar 13, 2019
Closed
@MIchaelMainer MIchaelMainer deleted the configurable-timeout-fix branch July 3, 2020 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@deepak2016 deepak2016 deepak2016 approved these changes

@dadheech115 dadheech115 dadheech115 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Provide the ability to customize the connection timeout values while also allowing default value

4 participants

@NakulSabharwal @deepak2016 @dadheech115