[#396] OneDrive Chunked Upload - Chunk size is not taken into consideration in case of customized input stream

[katestoycheva]

Fixes #396

Changes proposed in this pull request

• Continue to read from the input stream to make sure the buffer is filled with data until the chunk size is reached before executing the chunked upload request.

[ghost]

All CLA requirements met.

[zengin]

please re-scope the read variable and confirm whether not checking the empty buffer was intentional and whether my interpretation makes sense.

[katestoycheva]

Hi @zengin
I re-scoped the read variable and I confirm that your interpretation about not checking the empty buffer is correct.
Please review and let me know if anything else needs to be changed.

[zengin]

Looks good to me.

[davidmoten]

@katestoycheva just for curiosity how significant is this? What is this custom input stream? For my scenarios I don't care if a chunk ends up half the requested size but I do care if the chunk ends up 1% of the requested size repeatedly.

[zengin]

@davidmoten, there are more details in the attached issue. I think in @katestoycheva's example, the ratio is 32KB/5MB = 1/160.

#396

[davidmoten]

@zengin thanks!