-
Notifications
You must be signed in to change notification settings - Fork 233
Empty error reported in the SDK #353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baywet
suggested changes
Nov 10, 2020
zengin
reviewed
Nov 11, 2020
zengin
previously approved these changes
Nov 17, 2020
baywet
suggested changes
Nov 17, 2020
zengin
previously approved these changes
Nov 17, 2020
baywet
suggested changes
Dec 21, 2020
baywet
approved these changes
Dec 21, 2020
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#342
Problem -
However, I was able to get an empty response when I tried the following example to set the client-
export type AuthProviderCallback = (error: any, accessToken: string | null) => void;If the implementationof AuthProviderCallback created by the consumer returns an empty string for an access token and the error is set null, the response by the Graph SDK is an empty one with status code as -1 which could be confusing.
2. The GraphErrorHandler takes in error parameter of type 'any' but didn't handle, say error of type 'string', correctly.
Solution in this PR -
anytype error parameter that is passed appropriately .