Fixed Compilation error by changing property value param to accept array of strings in select, expand, orderby methods and by adding required libraries in config. #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expand, orderby methods. 2. Fixed compilation error by adding required libraries in config.
MIchaelMainer
approved these changes
May 23, 2018
| "removeComments": true, | ||
| "sourceMap": true, | ||
| "target": "es5", | ||
| "lib": ["es6", "dom"], |
Contributor
There was a problem hiding this comment.
What does this change do?
Contributor
Author
There was a problem hiding this comment.
We were getting compilation error Cannot find name for ES6 features like Map, Set, Symbol, WeakMap, WeakSet etc. This was because the compiler could not find a library having these feature set, so I have added es6 library which has them.
Ref: compiler options documentation
bullsseye
reviewed
May 25, 2018
Contributor
bullsseye
left a comment
bullsseye
left a comment
There was a problem hiding this comment.
Looks good. Can be merged if tested
Contributor
Author
|
I have tested. Shall I merge @MIchaelMainer ? |
Contributor
|
Please merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.