Fix failing unit tests under types directory, Remove hardcoded request urls, Remove beta endpoint usage and Use sdk modules from repo instead of using published package modules (this is correct way to test the code that is being changed) #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Remove hardcoded request urls 3. Remove beta endpoint usage 4. Use sdk modules from repo instead of using published package modules (this is correct way to test the code that is being changed)
deepak2016
approved these changes
Jul 10, 2018
bullsseye
reviewed
Jul 10, 2018
Contributor
bullsseye
left a comment
bullsseye
left a comment
There was a problem hiding this comment.
Looks good, please merge this if tested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.