-
Notifications
You must be signed in to change notification settings - Fork 215
Description
The welcome message is output as an object. Those with complex pipelines may get it introduced to "pollute" their output and that is difficult to troubleshoot, especially if they aren't intimately familiar with the process.
Instead, this should be adjusted to use Write-Host to go to the Information stream (Powershell 5.x+ which I assume is the target support surface) and then it can be suppressed with 6>$null, or even if not suppressed, it doesn't pollute the output stream.
Further, additional information on context would be nice to inform the user they did things right.
And an option switch e.g. -NoWelcome should be added for easy suppression for newer powershell users who may not understand they can suppress the information stream of the command with 6>$null
An example of what I think it should look like (ideally with a distinguishing color like Write-Host -foregroundcolor darkcyan)
Welcome to Microsoft Graph!
Connected via application using ClientId <CLientId>
Readme: https://github.com/microsoftgraph/msgraph-sdk-powershell/blob/dev/README.md
Graph Docs: https://docs.microsoft.com/en-us/graph/
NOTE: You can use the -NoWelcome parameter to suppress this message.
If this is tagged as up-for-grabs I'll be willing to attempt a PR
msgraph-sdk-powershell/src/Authentication/Authentication/Cmdlets/ConnectMgGraph.cs
Line 262 in 2da2646
| WriteObject("Welcome To Microsoft Graph!"); |
AB#7717