Skip to content

Conversation

@peombwa
Copy link
Member

@peombwa peombwa commented Aug 10, 2023

Fixes #512

Changes proposed in this pull request

  • Updates the SDK's welcome message to include links to the Readme doc, API docs, and SDK docs to aid in docs discoverability.
  • Adds -NoWelcome switch to Connect-MgGraph that customers can use to opt-out of the welcome message.

Limitations

Proposed Usage

Without -NoWelcome switch (default experience)

image

With `-NoWelcome

image

@peombwa peombwa marked this pull request as ready for review August 10, 2023 22:27
@peombwa peombwa requested a review from a team as a code owner August 10, 2023 22:27
@peombwa peombwa merged commit 8cf7d75 into dev Aug 14, 2023
@peombwa peombwa deleted the po/WelcomeMessage branch August 14, 2023 15:10
peombwa added a commit that referenced this pull request Aug 16, 2023
* Pluralizes person noun

* Add support for new states in RSC configuration.

* Add doc comments.

* Added directive to prevent null response objects

* Comments.

* Updated directive as per comment

* Update src/readme.graph.md

Co-authored-by: Peter Ombwa <peombwa@microsoft.com>

* Updated regex to include changes in  beta  cs files

* chore: Fix failing Authenticode validation due to ConvertFrom-Json changes.

* chore: Do not resolve paths.

* Update projectsbot.yml

* Update src/readme.graph.md

Co-authored-by: Peter Ombwa <peombwa@microsoft.com>

* Update projectsbot.yml

* chore: Run CI build on PR.

* Stash

* Updated raw api reference

* Updating examples

* Manually pulled TeamworkTeamAppSetting example

* Locally ran importation of teams examples

* Welcome Message Improvements (#2241)

* feat: Add SDK and API links to welcome message.

* chore: Use aka.ms links.

* Weekly OpenApiDocs Download.

* Add generated MgCommandMetadata.json. [run ci]

* Adds generated module artifacts

---------

Co-authored-by: Timothy Wamalwa <timwamalwa@gmail.com>
Co-authored-by: Subhajit Ray <subray@microsoft.com>
Co-authored-by: DeVere Dyett <ddyett@microsoft.com>
Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Welcome Message Improvements

3 participants