Skip to content

Rename wrongly named cmdlets to include MemberOf/TransitiveMemberOf/CreatedOnBehalfOf/ScopedRoleMemberOf #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 1, 2021
Merged

Rename wrongly named cmdlets to include MemberOf/TransitiveMemberOf/CreatedOnBehalfOf/ScopedRoleMemberOf #518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18dcbf9
Apply directive to fix wrongly named cmdlets.
peombwa Jan 26, 2021
1a60205
Regenerate module manifests.
peombwa Jan 26, 2021
c61fb8b
Merge branch 'dev' into bugfixes/MemberOfRename
peombwa Feb 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 36 additions & 15 deletions src/Applications/Applications/Microsoft.Graph.Applications.psd1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#
# Generated by: Microsoft Corporation
#
# Generated on: 8/25/2020
# Generated on: 1/25/2021
#

@{
Expand All @@ -12,13 +12,13 @@
RootModule = './Microsoft.Graph.Applications.psm1'

# Version number of this module.
ModuleVersion = '0.9.2'
ModuleVersion = '1.2.0'

# Supported PSEditions
CompatiblePSEditions = 'Core', 'Desktop'

# ID used to uniquely identify this module
GUID = 'a014f2cc-f37d-45f2-81bc-8062e00945ca'
GUID = 'b7e0ec6f-c535-43f3-ae90-08bd6a7851fa'

# Author of this module
Author = 'Microsoft Corporation'
Expand Down Expand Up @@ -51,7 +51,7 @@ DotNetFrameworkVersion = '4.7.2'
# ProcessorArchitecture = ''

# Modules that must be imported into the global environment prior to importing this module
RequiredModules = @(@{ModuleName = 'Microsoft.Graph.Authentication'; ModuleVersion = '0.9.1'; })
RequiredModules = @(@{ModuleName = 'Microsoft.Graph.Authentication'; ModuleVersion = '1.2.0'; })

# Assemblies that must be loaded prior to importing this module
RequiredAssemblies = './bin/Microsoft.Graph.Applications.private.dll'
Expand Down Expand Up @@ -82,8 +82,8 @@ FunctionsToExport = 'Add-MgApplicationKey', 'Add-MgApplicationPassword',
'Get-MgApplication', 'Get-MgApplicationAvailableExtensionProperty',
'Get-MgApplicationById', 'Get-MgApplicationConnectorGroup',
'Get-MgApplicationConnectorGroupByRef',
'Get-MgApplicationCreatedOnBehalf',
'Get-MgApplicationCreatedOnBehalfByRef', 'Get-MgApplicationDelta',
'Get-MgApplicationCreatedOnBehalfOf',
'Get-MgApplicationCreatedOnBehalfOfByRef', 'Get-MgApplicationDelta',
'Get-MgApplicationExtensionProperty',
'Get-MgApplicationHomeRealmDiscoveryPolicy',
'Get-MgApplicationHomeRealmDiscoveryPolicyByRef',
Expand All @@ -110,6 +110,10 @@ FunctionsToExport = 'Add-MgApplicationKey', 'Add-MgApplicationPassword',
'Get-MgOnPremisePublishingProfileAgentGroupPublishedResourceAgentGroup',
'Get-MgOnPremisePublishingProfileConnector',
'Get-MgOnPremisePublishingProfileConnectorGroup',
'Get-MgOnPremisePublishingProfileConnectorGroupApplication',
'Get-MgOnPremisePublishingProfileConnectorGroupApplicationByRef',
'Get-MgOnPremisePublishingProfileConnectorGroupMember',
'Get-MgOnPremisePublishingProfileConnectorMemberOf',
'Get-MgOnPremisePublishingProfilePublishedResource',
'Get-MgOnPremisePublishingProfilePublishedResourceAgentGroup',
'Get-MgOnPremisePublishingProfilePublishedResourceAgentGroupAgent',
Expand All @@ -122,13 +126,15 @@ FunctionsToExport = 'Add-MgApplicationKey', 'Add-MgApplicationPassword',
'Get-MgServicePrincipalClaimMappingPolicyByRef',
'Get-MgServicePrincipalCreatedObject',
'Get-MgServicePrincipalCreatedObjectByRef',
'Get-MgServicePrincipalDelegatedPermissionClassification',
'Get-MgServicePrincipalDelta', 'Get-MgServicePrincipalEndpoint',
'Get-MgServicePrincipalHomeRealmDiscoveryPolicy',
'Get-MgServicePrincipalHomeRealmDiscoveryPolicyByRef',
'Get-MgServicePrincipalLicenseDetail',
'Get-MgServicePrincipalMember', 'Get-MgServicePrincipalMemberByRef',
'Get-MgServicePrincipalMemberGroup',
'Get-MgServicePrincipalMemberObject',
'Get-MgServicePrincipalMemberOf',
'Get-MgServicePrincipalMemberOfByRef',
'Get-MgServicePrincipalOauth2PermissionGrant',
'Get-MgServicePrincipalOauth2PermissionGrantByRef',
'Get-MgServicePrincipalOwnedObject',
Expand All @@ -147,8 +153,8 @@ FunctionsToExport = 'Add-MgApplicationKey', 'Add-MgApplicationPassword',
'Get-MgServicePrincipalTokenIssuancePolicyByRef',
'Get-MgServicePrincipalTokenLifetimePolicy',
'Get-MgServicePrincipalTokenLifetimePolicyByRef',
'Get-MgServicePrincipalTransitiveMember',
'Get-MgServicePrincipalTransitiveMemberByRef',
'Get-MgServicePrincipalTransitiveMemberOf',
'Get-MgServicePrincipalTransitiveMemberOfByRef',
'Get-MgServicePrincipalUserOwnedObject',
'Get-MgUserAppRoleAssignment',
'Invoke-MgFilterApplicationSynchronizationJobSchemaOperator',
Expand Down Expand Up @@ -183,6 +189,8 @@ FunctionsToExport = 'Add-MgApplicationKey', 'Add-MgApplicationPassword',
'New-MgOnPremisePublishingProfileAgentGroupPublishedResourceAgentGroup',
'New-MgOnPremisePublishingProfileConnector',
'New-MgOnPremisePublishingProfileConnectorGroup',
'New-MgOnPremisePublishingProfileConnectorGroupApplicationByRef',
'New-MgOnPremisePublishingProfileConnectorMemberOf',
'New-MgOnPremisePublishingProfilePublishedResource',
'New-MgOnPremisePublishingProfilePublishedResourceAgentGroup',
'New-MgOnPremisePublishingProfilePublishedResourceAgentGroupAgent',
Expand All @@ -191,10 +199,11 @@ FunctionsToExport = 'Add-MgApplicationKey', 'Add-MgApplicationPassword',
'New-MgServicePrincipalAppRoleAssignment',
'New-MgServicePrincipalClaimMappingPolicyByRef',
'New-MgServicePrincipalCreatedObjectByRef',
'New-MgServicePrincipalDelegatedPermissionClassification',
'New-MgServicePrincipalEndpoint',
'New-MgServicePrincipalHomeRealmDiscoveryPolicyByRef',
'New-MgServicePrincipalLicenseDetail',
'New-MgServicePrincipalMemberByRef',
'New-MgServicePrincipalMemberOfByRef',
'New-MgServicePrincipalOauth2PermissionGrantByRef',
'New-MgServicePrincipalOwnedObjectByRef',
'New-MgServicePrincipalOwnerByRef',
Expand All @@ -206,11 +215,11 @@ FunctionsToExport = 'Add-MgApplicationKey', 'Add-MgApplicationPassword',
'New-MgServicePrincipalSynchronizationTemplateSchemaDirectory',
'New-MgServicePrincipalTokenIssuancePolicyByRef',
'New-MgServicePrincipalTokenLifetimePolicyByRef',
'New-MgServicePrincipalTransitiveMemberByRef',
'New-MgServicePrincipalTransitiveMemberOfByRef',
'New-MgUserAppRoleAssignment', 'Ping-MgApplicationsSynchronization',
'Ping-MgServicePrincipalsSynchronization', 'Remove-MgApplication',
'Remove-MgApplicationConnectorGroupByRef',
'Remove-MgApplicationCreatedOnBehalfByRef',
'Remove-MgApplicationCreatedOnBehalfOfByRef',
'Remove-MgApplicationExtensionProperty', 'Remove-MgApplicationKey',
'Remove-MgApplicationPassword',
'Remove-MgApplicationSynchronization',
Expand All @@ -229,13 +238,15 @@ FunctionsToExport = 'Add-MgApplicationKey', 'Add-MgApplicationPassword',
'Remove-MgOnPremisePublishingProfileAgentGroupPublishedResourceAgentGroup',
'Remove-MgOnPremisePublishingProfileConnector',
'Remove-MgOnPremisePublishingProfileConnectorGroup',
'Remove-MgOnPremisePublishingProfileConnectorMemberOf',
'Remove-MgOnPremisePublishingProfilePublishedResource',
'Remove-MgOnPremisePublishingProfilePublishedResourceAgentGroup',
'Remove-MgOnPremisePublishingProfilePublishedResourceAgentGroupAgent',
'Remove-MgOnPremisePublishingProfilePublishedResourceAgentGroupPublishedResource',
'Remove-MgServicePrincipal',
'Remove-MgServicePrincipalAppRoleAssignedTo',
'Remove-MgServicePrincipalAppRoleAssignment',
'Remove-MgServicePrincipalDelegatedPermissionClassification',
'Remove-MgServicePrincipalEndpoint', 'Remove-MgServicePrincipalKey',
'Remove-MgServicePrincipalLicenseDetail',
'Remove-MgServicePrincipalPassword',
Expand All @@ -252,7 +263,7 @@ FunctionsToExport = 'Add-MgApplicationKey', 'Add-MgApplicationPassword',
'Restart-MgServicePrincipalSynchronizationJob',
'Restore-MgApplication', 'Restore-MgServicePrincipal',
'Set-MgApplicationConnectorGroupByRef',
'Set-MgApplicationCreatedOnBehalfByRef', 'Set-MgApplicationLogo',
'Set-MgApplicationCreatedOnBehalfOfByRef', 'Set-MgApplicationLogo',
'Start-MgApplicationSynchronizationJob',
'Start-MgServicePrincipalSynchronizationJob',
'Stop-MgApplicationSynchronizationJob',
Expand Down Expand Up @@ -280,13 +291,15 @@ FunctionsToExport = 'Add-MgApplicationKey', 'Add-MgApplicationPassword',
'Update-MgOnPremisePublishingProfileAgentGroupPublishedResourceAgentGroup',
'Update-MgOnPremisePublishingProfileConnector',
'Update-MgOnPremisePublishingProfileConnectorGroup',
'Update-MgOnPremisePublishingProfileConnectorMemberOf',
'Update-MgOnPremisePublishingProfilePublishedResource',
'Update-MgOnPremisePublishingProfilePublishedResourceAgentGroup',
'Update-MgOnPremisePublishingProfilePublishedResourceAgentGroupAgent',
'Update-MgOnPremisePublishingProfilePublishedResourceAgentGroupPublishedResource',
'Update-MgServicePrincipal',
'Update-MgServicePrincipalAppRoleAssignedTo',
'Update-MgServicePrincipalAppRoleAssignment',
'Update-MgServicePrincipalDelegatedPermissionClassification',
'Update-MgServicePrincipalEndpoint',
'Update-MgServicePrincipalLicenseDetail',
'Update-MgServicePrincipalPasswordSingleSignOnCredentials',
Expand All @@ -306,7 +319,15 @@ CmdletsToExport = @()
# VariablesToExport = @()

# Aliases to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no aliases to export.
AliasesToExport = '*'
AliasesToExport = 'Get-MgApplicationCreatedOnBehalf',
'Get-MgApplicationCreatedOnBehalfByRef',
'Get-MgServicePrincipalMember', 'Get-MgServicePrincipalMemberByRef',
'Get-MgServicePrincipalTransitiveMember',
'Get-MgServicePrincipalTransitiveMemberByRef',
'New-MgServicePrincipalMemberByRef',
'New-MgServicePrincipalTransitiveMemberByRef',
'Remove-MgApplicationCreatedOnBehalfByRef',
'Set-MgApplicationCreatedOnBehalfByRef'

# DSC resources to export from this module
# DscResourcesToExport = @()
Expand Down Expand Up @@ -335,7 +356,7 @@ PrivateData = @{
ProjectUri = 'https://github.com/microsoftgraph/msgraph-sdk-powershell'

# A URL to an icon representing this module.
IconUri = 'https://raw.githubusercontent.com/microsoftgraph/g-raph/master/g-raph.png'
IconUri = 'https://raw.githubusercontent.com/microsoftgraph/msgraph-sdk-powershell/master/documentation/images/graph_color256.png'

# ReleaseNotes of this module
ReleaseNotes = 'See https://aka.ms/GraphPowerShell-Release.'
Expand Down
9 changes: 9 additions & 0 deletions src/Applications/Applications/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,15 @@ directive:
subject: (Application|ServicePrincipal)SynchronizationJobCredentials
variant: Validate1|ValidateExpanded1|ValidateViaIdentity1|ValidateViaIdentityExpanded1
remove: true
# Alias then rename cmdlets to avoid breaking change.
- where:
subject: ^(ServicePrincipal|Application)(Member|TransitiveMember|CreatedOnBehalf)$
set:
alias: ${verb}-Mg${subject}
- where:
subject: ^(ServicePrincipal|Application)(Member|TransitiveMember|CreatedOnBehalf)$
set:
subject: $1$2Of
# Rename wrongly named cmdlets
- where:
verb: Get
Expand Down
33 changes: 18 additions & 15 deletions src/Groups/Groups/Microsoft.Graph.Groups.psd1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#
# Generated by: Microsoft Corporation
#
# Generated on: 8/25/2020
# Generated on: 1/25/2021
#

@{
Expand All @@ -12,13 +12,13 @@
RootModule = './Microsoft.Graph.Groups.psm1'

# Version number of this module.
ModuleVersion = '0.9.2'
ModuleVersion = '1.2.0'

# Supported PSEditions
CompatiblePSEditions = 'Core', 'Desktop'

# ID used to uniquely identify this module
GUID = '804f073f-e282-4562-9171-7d6fe134987e'
GUID = '0b410dab-6817-40dd-b2da-4f6519946b47'

# Author of this module
Author = 'Microsoft Corporation'
Expand Down Expand Up @@ -51,7 +51,7 @@ DotNetFrameworkVersion = '4.7.2'
# ProcessorArchitecture = ''

# Modules that must be imported into the global environment prior to importing this module
RequiredModules = @(@{ModuleName = 'Microsoft.Graph.Authentication'; ModuleVersion = '0.9.1'; })
RequiredModules = @(@{ModuleName = 'Microsoft.Graph.Authentication'; ModuleVersion = '1.2.0'; })

# Assemblies that must be loaded prior to importing this module
RequiredAssemblies = './bin/Microsoft.Graph.Groups.private.dll'
Expand Down Expand Up @@ -85,7 +85,7 @@ FunctionsToExport = 'Add-MgGroupFavorite', 'Add-MgGroupToLifecyclePolicy',
'Get-MgGroupConversationThreadPostMention',
'Get-MgGroupConversationThreadPostMultiValueExtendedProperty',
'Get-MgGroupConversationThreadPostSingleValueExtendedProperty',
'Get-MgGroupCreatedOnBehalf', 'Get-MgGroupCreatedOnBehalfByRef',
'Get-MgGroupCreatedOnBehalfOf', 'Get-MgGroupCreatedOnBehalfOfByRef',
'Get-MgGroupDelta', 'Get-MgGroupEndpoint', 'Get-MgGroupEventDelta',
'Get-MgGroupExtension', 'Get-MgGroupLifecyclePolicy',
'Get-MgGroupMember', 'Get-MgGroupMemberByRef',
Expand All @@ -96,7 +96,8 @@ FunctionsToExport = 'Add-MgGroupFavorite', 'Add-MgGroupToLifecyclePolicy',
'Get-MgGroupOnenoteNotebookFromWebUrl',
'Get-MgGroupOnenoteRecentNotebook', 'Get-MgGroupOwner',
'Get-MgGroupOwnerByRef', 'Get-MgGroupPermissionGrant',
'Get-MgGroupPhoto', 'Get-MgGroupRejectedSender', 'Get-MgGroupSetting',
'Get-MgGroupPhoto', 'Get-MgGroupPhotoContent',
'Get-MgGroupRejectedSender', 'Get-MgGroupSetting',
'Get-MgGroupThread', 'Get-MgGroupThreadPost',
'Get-MgGroupThreadPostAttachment', 'Get-MgGroupThreadPostExtension',
'Get-MgGroupThreadPostMention',
Expand Down Expand Up @@ -157,7 +158,7 @@ FunctionsToExport = 'Add-MgGroupFavorite', 'Add-MgGroupToLifecyclePolicy',
'Remove-MgGroupConversationThreadPostMention',
'Remove-MgGroupConversationThreadPostMultiValueExtendedProperty',
'Remove-MgGroupConversationThreadPostSingleValueExtendedProperty',
'Remove-MgGroupCreatedOnBehalfByRef', 'Remove-MgGroupEndpoint',
'Remove-MgGroupCreatedOnBehalfOfByRef', 'Remove-MgGroupEndpoint',
'Remove-MgGroupExtension', 'Remove-MgGroupFavorite',
'Remove-MgGroupFromLifecyclePolicy',
'Remove-MgGroupLifecyclePolicy', 'Remove-MgGroupPermissionGrant',
Expand All @@ -169,12 +170,12 @@ FunctionsToExport = 'Add-MgGroupFavorite', 'Add-MgGroupToLifecyclePolicy',
'Remove-MgGroupThreadPostMultiValueExtendedProperty',
'Remove-MgGroupThreadPostSingleValueExtendedProperty',
'Remove-MgUserJoinedGroup', 'Reset-MgGroupUnseenCount',
'Restore-MgGroup', 'Set-MgGroupCreatedOnBehalfByRef',
'Set-MgGroupLicense', 'Stop-MgGroupCalendarEvent',
'Stop-MgGroupEvent', 'Test-MgGroupDynamicMembership',
'Test-MgGroupProperty', 'Update-MgGroup',
'Update-MgGroupAcceptedSender', 'Update-MgGroupConversation',
'Update-MgGroupConversationThread',
'Restore-MgGroup', 'Set-MgGroupCreatedOnBehalfOfByRef',
'Set-MgGroupLicense', 'Set-MgGroupPhotoContent',
'Stop-MgGroupCalendarEvent', 'Stop-MgGroupEvent',
'Test-MgGroupDynamicMembership', 'Test-MgGroupProperty',
'Update-MgGroup', 'Update-MgGroupAcceptedSender',
'Update-MgGroupConversation', 'Update-MgGroupConversationThread',
'Update-MgGroupConversationThreadPost',
'Update-MgGroupConversationThreadPostAttachment',
'Update-MgGroupConversationThreadPostExtension',
Expand All @@ -200,7 +201,9 @@ CmdletsToExport = @()
# VariablesToExport = @()

# Aliases to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no aliases to export.
AliasesToExport = '*'
AliasesToExport = 'Get-MgGroupCreatedOnBehalf', 'Get-MgGroupCreatedOnBehalfByRef',
'Remove-MgGroupCreatedOnBehalfByRef',
'Set-MgGroupCreatedOnBehalfByRef'

# DSC resources to export from this module
# DscResourcesToExport = @()
Expand Down Expand Up @@ -229,7 +232,7 @@ PrivateData = @{
ProjectUri = 'https://github.com/microsoftgraph/msgraph-sdk-powershell'

# A URL to an icon representing this module.
IconUri = 'https://raw.githubusercontent.com/microsoftgraph/g-raph/master/g-raph.png'
IconUri = 'https://raw.githubusercontent.com/microsoftgraph/msgraph-sdk-powershell/master/documentation/images/graph_color256.png'

# ReleaseNotes of this module
ReleaseNotes = 'See https://aka.ms/GraphPowerShell-Release.'
Expand Down
10 changes: 9 additions & 1 deletion src/Groups/Groups/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,15 @@ directive:
subject: ^(GroupOnenoteNotebookSectionGroupSectionPage)$
set:
subject: $1Content

# Alias then rename cmdlets to avoid breaking change.
- where:
subject: ^(Group)(CreatedOnBehalf)$
set:
alias: ${verb}-Mg${subject}
- where:
subject: ^(Group)(CreatedOnBehalf)$
set:
subject: $1$2Of
```
### Versioning

Expand Down
Loading