Skip to content

Interactive Authentication #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Apr 27, 2021
Merged

Interactive Authentication #618

merged 19 commits into from
Apr 27, 2021

Conversation

@georgend
Copy link
Contributor

@georgend georgend commented Apr 13, 2021 •
edited
Loading

  • Set InteractiveAuthenticationProvider as the default auth provider.
  • Inform the user of fallback to device code when Interactive Auth is unavailable due to browser not being available such as Azure CloudShell and WSL.
  • Minor cleanup, remove unused methods.
  • Add default redirect Url to PowerShell SDK App Registration. Done by @darrelmiller as detailed in MSAL Docs

Examples
Environment: Windows
PowerShell - Opens a Browser Windows/Tab
Windows PowerShell - Opens a Pop-Up Window
Environment : WSL
Falls Back to DeviceCode
image
Specifying -UseDeviceAuthentication
image

Resolves #555, #334

Make Interactive Auth the default auth provider.
ae869ae 
Inform the user of fallback to device code when Interactive Auth is unavailable due to browser not being available such as CloudShell and WSL.
Minor cleanup, remove unused methods.
@georgend georgend added the Auth label Apr 13, 2021
@georgend georgend added this to the 1.5.0 milestone Apr 13, 2021
@georgend georgend self-assigned this Apr 13, 2021
@georgend georgend requested a review from peombwa April 13, 2021 11:09
@georgend georgend linked an issue Apr 13, 2021 that may be closed by this pull request
Implement interactive sign-in #555
Closed
@georgend georgend marked this pull request as ready for review April 13, 2021 11:10
@darrelmiller
Copy link
Contributor

darrelmiller commented Apr 13, 2021

Hey @finsharp ! It is great to see this work. I look forward to trying it out.

peombwa
peombwa reviewed Apr 14, 2021
View reviewed changes
George and others added 3 commits April 16, 2021 17:53
Update MSAL to 4.29.
fcbf320 
Add Microsoft.WIndows.SDK.Contracts as a direct dependency, as it was transient before via MSAL 4.23
Handle case when browser may not open or other unexpected error condition.
Minor refatoring.
@georgend @peombwa
Update src/Authentication/Authentication/Properties/Resources.resx
14627f0 
Co-authored-by: Peter Ombwa <peter.ombwa@microsoft.com>
@georgend
Merge branch 'dev' into features/interactiveAuthentication
8e7f5bb
peombwa
peombwa requested changes Apr 20, 2021
View reviewed changes
@georgend
Copy link
Contributor Author

georgend commented Apr 20, 2021

@peombwa
There are two scenarios.

  • A user may not be in an interactive session. - We detect this by the call to IsUserInteractive()
  • A User may be in an interactive session but for some reason (Browser not installed for example) the browser fails to open. - This can only be known through the exception thrown. Thus we need to fallback to DeviceCode auth in this scenario. Thats where the recursion in the catch block comes in.

@peombwa peombwa modified the milestones: 1.5.0, 1.6.0 Apr 20, 2021
georgend and others added 2 commits April 22, 2021 21:12
@georgend
Merge branch 'dev' into features/interactiveAuthentication
8388689
Simplify fallback Logic.
4b4f65c 
Store AuthProviderType in AuthContext.
Add test for fallback scenario.
@georgend georgend requested a review from peombwa April 22, 2021 22:27
@georgend georgend merged commit e722f52 into dev Apr 27, 2021
@georgend georgend deleted the features/interactiveAuthentication branch April 27, 2021 18:19
This was referenced Apr 29, 2021
Merged
Closed
@peombwa peombwa mentioned this pull request May 26, 2021
Merged
@peombwa peombwa mentioned this pull request Jun 2, 2021
Merged
This was referenced Jun 9, 2021
Merged
Closed
Closed
@peombwa peombwa mentioned this pull request Jul 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peombwa peombwa peombwa approved these changes

@ddyett ddyett Awaiting requested review from ddyett

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

Assignees

@georgend georgend

Labels

Auth

Projects

None yet

Milestone

1.6.0

Development

Successfully merging this pull request may close these issues.

Implement interactive sign-in

4 participants

@georgend @darrelmiller @peombwa