Enable Support for PowerShell ISE by handling output via Cmdlet methods. #668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peombwa
reviewed
May 19, 2021
src/Authentication/Authentication.Core/Interfaces/IAuthContext.cs
Outdated
Show resolved
Hide resolved
src/Authentication/Authentication/Common/GraphSessionInitializer.cs
Outdated
Show resolved
Hide resolved
refactor session initializer.
…h/msgraph-sdk-powershell into features/ISEOutput
peombwa
reviewed
May 20, 2021
src/Authentication/Authentication/Common/GraphSessionInitializer.cs
Outdated
Show resolved
Hide resolved
Cannot initialize output on Module import, thus init on module execution. use async command runtime to handle output.
ddyett
reviewed
May 21, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On module importation, pass along PSCmdlet to gain access to output methods from the cmdlet.
Remove references to
Console.Outwhich is not available in PowerShell ISE. It uses the methods from the Cmdlets to write to outputs correctly.Current Behavior
Proposed Behavior