Skip to content

Log Warning Headers to PS's Warning Stream #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 3, 2021
Merged

Log Warning Headers to PS's Warning Stream #957

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6cfa9fb
Log warning headers into PS Warning stream.
peombwa Nov 20, 2021
4177705
Merge branch 'dev' into features/LogWarningHeaders
peombwa Nov 30, 2021
065598c
Merge branch 'dev' into features/LogWarningHeaders
peombwa Dec 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tools/Custom/Module.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,12 @@ private async Task OnResponseCreated(string id, CancellationToken cancellationTo
var response = eventData?.ResponseMessage as HttpResponseMessage;
if (response != null)
{
if (response.Headers.Warning != null)
{
string warningHeader = response.Headers.Warning.ToString();
await signal(Events.Warning, cancellationToken,
() => EventFactory.CreateWarningEvent(warningHeader));
}
// Log request after response since all our request header are set via middleware pipeline.
var request = response?.RequestMessage;
if (request != null)
Expand Down