fix: guard against NULL/empty DACL to prevent wiping drive root permissions#13
Merged
Conversation
…ssions When a directory (e.g. C:\) has a NULL DACL (no DACL section at all), GetAccessControl() returns zero rules. Adding our AppContainer ACE and calling SetAccessControl() then replaces the implicit full-access with a single-entry DACL, stripping Administrators/Users/SYSTEM permissions. Add IsNullOrEmptyDacl() helper that inspects the SDDL string for a missing or empty D: section. Guard all three ACL-write paths: - GrantAccess (dir + file branches) - GrantAncestorTraverse - SetupDriveTraverse NULL DACL semantically grants everyone full access (including AppContainer), so skipping the write is functionally correct.
xieyangsp
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a directory (e.g. C:) has a NULL DACL (no DACL section at all), GetAccessControl() returns zero rules. Adding our AppContainer ACE and calling SetAccessControl() then replaces the implicit full-access with a single-entry DACL, stripping Administrators/Users/SYSTEM permissions.
Add IsNullOrEmptyDacl() helper that inspects the SDDL string for a missing or empty D: section. Guard all three ACL-write paths:
NULL DACL semantically grants everyone full access (including AppContainer), so skipping the write is functionally correct.
Description
Related Issue
Changes
Type of Change
Testing
cd desktop && npm run test)cd desktop/renderer && npm run test)cd desktop && npm run build)Checklist