This repository was archived by the owner on Jan 9, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lazy collections implementation -LazyArrayList -LazyHashMap -LazyHashSet
fh-ms
reviewed
Jan 24, 2023
Contributor
fh-ms
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some 'format' comments, and then I realized that there are a lot of places where the indentation is odd, but maybe it is just the GitHub viewer.
base/src/main/java/one/microstream/collections/lazy/LazyCollection.java
Outdated
Show resolved
Hide resolved
base/src/main/java/one/microstream/collections/lazy/LazyArrayList.java
Outdated
Show resolved
Hide resolved
base/src/main/java/one/microstream/collections/lazy/LazyArrayList.java
Outdated
Show resolved
Hide resolved
base/src/main/java/one/microstream/collections/lazy/LazyArrayList.java
Outdated
Show resolved
Hide resolved
base/src/main/java/one/microstream/reference/LazyClearObserver.java
Outdated
Show resolved
Hide resolved
base/src/main/java/one/microstream/reference/ObservedLazyReference.java
Outdated
Show resolved
Hide resolved
- fixed whitespaces - renamed ObservedLazyReference to ControlledLazyReference - renamed BinaryHandlerLazyObservable to BinaryHandlerControlledLazy - renamed LazyClearObserver to LazyClearController - made lazy collections implementations final - made LazySegmentUnloader implementations final - made binary handler final
fh-ms
reviewed
Jan 24, 2023
Contributor
fh-ms
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last typo.
base/src/main/java/one/microstream/reference/ControlledLazyReference.java
Outdated
Show resolved
Hide resolved
fh-ms
approved these changes
Jan 24, 2023
zdenek-jonas
approved these changes
Jan 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lazy collections implementation
-LazyArrayList
-LazyHashMap
-LazyHashSet