Skip to content

Fix HTTP method mismatch and remove unnecessary intercepts in navigation menu Cypress tests #7273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
renemadsen merged 3 commits into from
Nov 11, 2025
Merged

Fix HTTP method mismatch and remove unnecessary intercepts in navigation menu Cypress tests #7273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4844ad5
Initial plan
Copilot Nov 11, 2025
47115de
Fix HTTP method in navigation menu tests - change POST to PUT
Copilot Nov 11, 2025
26575df
Remove saveMenuEdit intercepts to match reference implementation
Copilot Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions eform-client/cypress/e2e/c/navigation-menu.delete-item.spec.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ describe('Navigation menu - Delete item', function () {
navigationMenuPage.getDropdownBodyChilds(currentCount - 1).should('have.length', 3);

// Save menu
cy.intercept('POST', '**/api/navigation-menu').as('saveMenu');
cy.intercept('PUT', '**/api/navigation-menu').as('saveMenu');
navigationMenuPage.clickSaveMenuBtn();
cy.wait('@saveMenu', { timeout: 30000 });
});
Expand All @@ -58,7 +58,7 @@ describe('Navigation menu - Delete item', function () {
navigationMenuPage.deleteElementFromDropdown(menuItemsCount - 1, 0);
navigationMenuPage.deleteElementFromDropdown(menuItemsCount - 1, 0);

cy.intercept('POST', '**/api/navigation-menu').as('saveMenu1');
cy.intercept('PUT', '**/api/navigation-menu').as('saveMenu1');
navigationMenuPage.clickSaveMenuBtn();
cy.wait('@saveMenu1', { timeout: 30000 });

Expand All @@ -72,7 +72,7 @@ describe('Navigation menu - Delete item', function () {
navigationMenuPage.getMenuItems().its('length').then(currentCount => {
navigationMenuPage.deleteElementFromMenuItems(currentCount - 1); // delete created dropdown

cy.intercept('POST', '**/api/navigation-menu').as('saveMenu2');
cy.intercept('PUT', '**/api/navigation-menu').as('saveMenu2');
navigationMenuPage.clickSaveMenuBtn();
cy.wait('@saveMenu2', { timeout: 30000 });

Expand Down
6 changes: 2 additions & 4 deletions eform-client/cypress/e2e/c/navigation-menu.drag-item.spec.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ describe('Navigation menu - Drag item', function () {
navigationMenuPage.editTranslationsOnDropdownBodyChilds(data);
});

cy.intercept('POST', '**/api/navigation-menu').as('saveMenu');
cy.intercept('PUT', '**/api/navigation-menu').as('saveMenu');
navigationMenuPage.clickSaveMenuBtn();
cy.wait('@saveMenu', { timeout: 30000 });

Expand All @@ -74,9 +74,7 @@ describe('Navigation menu - Drag item', function () {
.should('have.value', translation);
});

cy.intercept('POST', '**/api/navigation-menu').as('saveMenuEdit');
navigationMenuPage.editItemSave();
cy.wait('@saveMenuEdit', { timeout: 30000 });
});
});
});
Expand All @@ -86,7 +84,7 @@ describe('Navigation menu - Drag item', function () {
// Swap elements within dropdown
navigationMenuPage.dragAndDropElementOfDropdown(menuCount, 2, 0);

cy.intercept('POST', '**/api/navigation-menu').as('saveMenu');
cy.intercept('PUT', '**/api/navigation-menu').as('saveMenu');
navigationMenuPage.clickSaveMenuBtn();
cy.wait('@saveMenu', { timeout: 30000 });

Expand Down
18 changes: 5 additions & 13 deletions eform-client/cypress/e2e/c/navigation-menu.edit-item.spec.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ describe('Navigation menu - Edit item', function () {

navigationMenuPage.getMenuItems().should('have.length', initialCount + 1);

cy.intercept('POST', '**/api/navigation-menu').as('saveMenu');
cy.intercept('PUT', '**/api/navigation-menu').as('saveMenu');
navigationMenuPage.clickSaveMenuBtn();
cy.wait('@saveMenu', { timeout: 30000 });
});
Expand All @@ -41,7 +41,7 @@ describe('Navigation menu - Edit item', function () {
navigationMenuPage.getMenuItems().its('length').then(count => {
navigationMenuPage.editCustomLink(customLink, count - 1);

cy.intercept('POST', '**/api/navigation-menu').as('saveMenu');
cy.intercept('PUT', '**/api/navigation-menu').as('saveMenu');
navigationMenuPage.clickSaveMenuBtn();
cy.wait('@saveMenu', { timeout: 30000 });

Expand All @@ -60,9 +60,7 @@ describe('Navigation menu - Edit item', function () {
cy.get(`#editItemTranslation${count - 1}_0_${i}`).should('have.value', translation);
});

cy.intercept('POST', '**/api/navigation-menu').as('saveMenuEdit');
navigationMenuPage.editItemSave();
cy.wait('@saveMenuEdit', { timeout: 30000 });
});
});

Expand All @@ -78,7 +76,7 @@ describe('Navigation menu - Edit item', function () {

navigationMenuPage.getMenuItems().should('have.length', initialCount + 1);

cy.intercept('POST', '**/api/navigation-menu').as('saveMenu');
cy.intercept('PUT', '**/api/navigation-menu').as('saveMenu');
navigationMenuPage.clickSaveMenuBtn();
cy.wait('@saveMenu', { timeout: 30000 });
});
Expand All @@ -93,7 +91,7 @@ describe('Navigation menu - Edit item', function () {
navigationMenuPage.getMenuItems().its('length').then(count => {
navigationMenuPage.editCustomDropdown(dropdown, count - 1);

cy.intercept('POST', '**/api/navigation-menu').as('saveMenu');
cy.intercept('PUT', '**/api/navigation-menu').as('saveMenu');
navigationMenuPage.clickSaveMenuBtn();
cy.wait('@saveMenu', { timeout: 30000 });

Expand All @@ -109,9 +107,7 @@ describe('Navigation menu - Edit item', function () {
cy.get(`#editItemTranslation${count - 1}_0_${i}`).should('have.value', translation);
});

cy.intercept('POST', '**/api/navigation-menu').as('saveMenuEdit');
navigationMenuPage.editItemSave();
cy.wait('@saveMenuEdit', { timeout: 30000 });
});
});

Expand All @@ -122,7 +118,7 @@ describe('Navigation menu - Edit item', function () {

navigationMenuPage.getMenuItems().should('have.length', initialCount + 1);

cy.intercept('POST', '**/api/navigation-menu').as('saveMenu');
cy.intercept('PUT', '**/api/navigation-menu').as('saveMenu');
navigationMenuPage.clickSaveMenuBtn();
cy.wait('@saveMenu', { timeout: 30000 });

Expand All @@ -142,9 +138,7 @@ describe('Navigation menu - Edit item', function () {

cy.get('#editLinkInput').should('have.value', data.link);

cy.intercept('POST', '**/api/navigation-menu').as('saveMenuEdit');
navigationMenuPage.editItemSave();
cy.wait('@saveMenuEdit', { timeout: 30000 });
});

it('element must be updated on translation fields', () => {
Expand All @@ -164,9 +158,7 @@ describe('Navigation menu - Edit item', function () {
}
});

cy.intercept('POST', '**/api/navigation-menu').as('saveMenuEdit');
navigationMenuPage.editItemSave();
cy.wait('@saveMenuEdit', { timeout: 30000 });
});

afterEach(() => {
Expand Down
Loading