Skip to content

Fix drag-and-drop into dropdown menu items #7275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
renemadsen merged 2 commits into from
Nov 11, 2025
Merged

Fix drag-and-drop into dropdown menu items #7275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50b60cb
Initial plan
Copilot Nov 11, 2025
2f782d4
Fix drag and drop for menu items into dropdown bodies
Copilot Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...dules/navigation-menu/components/navigation-menu-page/navigation-menu-page.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
class="dragula-template"
cdkDropList
[cdkDropListData]="menuTemplate.items"
[cdkDropListConnectedTo]="['actualMenuList']"
[cdkDropListConnectedTo]="['actualMenuList'].concat(connectedDropdownIds)"
id="mainMenu"
>
<app-navigation-menu-template-item
Expand Down Expand Up @@ -98,6 +98,7 @@
<div
class="dropdownBody"
cdkDropList
[id]="getDropdownId(firstLevelIndex)"
[cdkDropListData]="menuItem.children"
[cdkDropListConnectedTo]="['mainMenu']"
(cdkDropListDropped)="dropMenuItemChild($event, firstLevelIndex)"
Expand Down
10 changes: 10 additions & 0 deletions ...modules/navigation-menu/components/navigation-menu-page/navigation-menu-page.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,16 @@ export class NavigationMenuPageComponent implements OnInit, OnDestroy {
return NavigationMenuItemTypeEnum;
}

getDropdownId(index: number): string {
return `dropdown-${index}`;
}

get connectedDropdownIds(): string[] {
return this.navigationMenuModel.actualMenu
.map((item, index) => item.type === NavigationMenuItemTypeEnum.Dropdown ? this.getDropdownId(index) : null)
.filter(id => id !== null) as string[];
}

constructor() {
}

Expand Down
Loading