fix(server): avoid crashing server when using ws adapter by logging error

fixes #1615

Author: dinwwwh

packages/server/src/adapters/ws/handler.ts

@@ -5,7 +5,7 @@ import type { StandardHandler } from '../standard'
 import type {
   HandleStandardServerPeerMessageOptions,
 } from '../standard-peer'
-import { readAsBuffer, resolveMaybeOptionalOptions } from '@orpc/shared'
+import { logError, readAsBuffer, resolveMaybeOptionalOptions } from '@orpc/shared'
 import { ServerPeer } from '@orpc/standard-server-peer'
 import { createServerPeerHandleRequestFn } from '../standard-peer'
 
@@ -26,10 +26,19 @@ export class WsHandler<T extends Context> {
         ? await readAsBuffer(new Blob(event.data))
         : event.data
 
-      await peer.message(
-        message,
-        createServerPeerHandleRequestFn(this.standardHandler, resolveMaybeOptionalOptions(rest)),
-      )
+      try {
+        await peer.message(
+          message,
+          createServerPeerHandleRequestFn(this.standardHandler, resolveMaybeOptionalOptions(rest)),
+        )
+      }
+      catch (error) {
+        /**
+         * Users cannot catch errors thrown by this `peer.message`, and node.js may
+         * crash on unhandled rejections, so we log the error here to prevent that.
+         */
+        logError(error)
+      }
     })
 
     ws.addEventListener('close', () => {

packages/server/src/adapters/ws/rpc-handler.test.ts

@@ -1,7 +1,10 @@
+import * as Shared from '@orpc/shared'
 import { encodeRequestMessage, MessageType } from '@orpc/standard-server-peer'
 import { os } from '../../builder'
 import { RPCHandler } from './rpc-handler'
 
+const logErrorSpy = vi.spyOn(Shared, 'logError').mockImplementation(() => {})
+
 describe('rpcHandler', async () => {
   let signal: AbortSignal
 
@@ -70,4 +73,14 @@ describe('rpcHandler', async () => {
     await vi.waitFor(() => expect(signal.aborted).toBe(true))
     expect(wss.send).not.toHaveBeenCalled()
   })
+
+  it('logs error on message handler error instead of throwing', async () => {
+    onMessage({
+      data: 'invalid message that will cause an error',
+    })
+
+    await vi.waitFor(() => {
+      expect(logErrorSpy).toHaveBeenCalledWith(expect.any(Error))
+    })
+  })
 })

packages/shared/src/index.ts

@@ -10,6 +10,7 @@ export * from './id'
 export * from './interceptor'
 export * from './iterator'
 export * from './json'
+export * from './log'
 export * from './object'
 export * from './otel'
 export * from './proxy'

packages/shared/src/log.test.ts

@@ -0,0 +1,21 @@
+import { logError } from './log'
+
+describe('logError', () => {
+  it('should log error to console.error', () => {
+    const consoleErrorSpy = vi.spyOn(console, 'error').mockImplementation(() => {})
+    const error = new Error('Test error')
+    logError(error)
+    expect(consoleErrorSpy).toHaveBeenCalledWith(error)
+    consoleErrorSpy.mockRestore()
+  })
+
+  it('should do nothing if console.error is not available', () => {
+    const originalConsoleError = console.error
+    // @ts-expect-error: Temporarily override console.error for testing
+    console.error = undefined
+    const error = new Error('Test error')
+    expect(() => logError(error)).not.toThrow()
+    // Restore the original console.error function
+    console.error = originalConsoleError
+  })
+})

packages/shared/src/log.ts

@@ -0,0 +1,5 @@
+export function logError(error: unknown): void {
+  if (typeof console === 'object' && typeof console.error === 'function') {
+    console.error(error)
+  }
+}