feat(openapi)!: replace shouldHoistDef with customComponentName option in generator - #1728
Merged
dinwwwh merged 1 commit intoJul 26, 2026
Conversation
Root-level `$defs` are now always hoisted into `components.schemas`, and `customComponentName` lets users rename the resulting components instead. Error components no longer carry the default message in their `message` schema, so procedures sharing an error code reuse a single component.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
More templates
@orpc/ai-sdk
@orpc/arktype
@orpc/bun
@orpc/client
@orpc/cloudflare
@orpc/contract
@orpc/experimental-effect
@orpc/evlog
@orpc/json-schema
@orpc/nest
@orpc/next
@orpc/openapi
@orpc/opentelemetry
@orpc/pinia-colada
@orpc/pino
@orpc/publisher
@orpc/ratelimit
@orpc/server
@orpc/shared
@orpc/swr
@orpc/tanstack-query
@orpc/trpc
@orpc/valibot
@orpc/zod
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — this PR removes shouldHoistDef and replaces it with customComponentName. All root-level $defs are now always hoisted into components.schemas; customComponentName controls how they're renamed. Error components also shed their baked-in default message for better reuse.
customComponentNamereplacesshouldHoistDef— theOpenAPIComponentRegistryconstructor andOpenAPIGeneratorGenerateOptionsnow accept a(defName, defSchema) => string | undefinedcallback instead of aValue<boolean>predicate. All defs are always hoisted.- ~90 lines of dead code removed —
visitLocalDefRefs,hoistReferencedLocalDefs,withReferencedLocalDefs, andcollectReferencedLocalDefNamesare gone, along with unused imports ofvisitJsonSchemaRefsandValue. - Error message
defaultremoved — error components no longer carry the per-proceduredefaultMessagein theirmessageschema. Procedures sharing the same error code but with different messages now reuse the same component. - Docs updated — the specification docs reflect the new
customComponentNameAPI.
DeepSeek Pro (free via Pullfrog for OSS) | 𝕏
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Root-level
$defsare now always hoisted intocomponents.schemas. TheshouldHoistDefoption is gone, replaced bycustomComponentNamefor renaming the resulting components.undefinedkeeps the original def name.Planet,PlanetInput,Planet2, ...).messageschema. Procedures that declare the same error code with different messages now share one component, and the message still shows up in the response description.