feat(contract): validate data in error factory constructor - #1765
Merged
dinwwwh merged 1 commit intoAug 2, 2026
Merged
Conversation
The error factory constructor now validates data against the schema: invalid data throws a ValidationError and the validated schema output is what gets stored on the error. Since both the constructor and instanceof now validate synchronously, the sync-schema requirement is factory-wide; the async-schema TypeError is unified into one shared helper and the docs warning moved from the instanceof subsection to the main Error Factory section.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
More templates
@orpc/ai-sdk
@orpc/arktype
@orpc/bun
@orpc/client
@orpc/cloudflare
@orpc/contract
@orpc/experimental-effect
@orpc/evlog
@orpc/json-schema
@orpc/nest
@orpc/next
@orpc/openapi
@orpc/opentelemetry
@orpc/pinia-colada
@orpc/pino
@orpc/publisher
@orpc/ratelimit
@orpc/server
@orpc/shared
@orpc/swr
@orpc/tanstack-query
@orpc/trpc
@orpc/valibot
@orpc/zod
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Constructor data validation — the error factory constructor now validates
datathrough a sharedvalidateDatahelper, throwingValidationErroron invalid input and storing the schema-transformed output. Async schemas throw aTypeErrorwith a consistent message across both constructor andinstanceofpaths. - Deduplicated async-schema check — the
Symbol.hasInstancepath now delegates to the samevalidateDatahelper instead of inlining an identically-shaped block. ThedataSchemaguard on theinstanceofpath also avoids an unnecessary passthrough-schema call for factories without a schema. - Docs sync — the sync-schema warning moved from the old
instanceof-only subsection to the Error Factory options JSDoc and the doc page, and the@paramtags were removed (the TS types already cover them).
DeepSeek Pro (free via Pullfrog for OSS) | 𝕏
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The error factory constructor now validates
dataagainst the schema instead of only validating duringinstanceofchecks. Invalid data throws aValidationError(withissuesandinvalidData, same class used by input/output validation), and the validated schema output is what gets stored on the error - so schema transforms like zod's unknown-key stripping now apply to constructed errors.Behavior
instanceofvalidate synchronously, the sync-schema requirement is now factory-wide: an async data schema throws the sameTypeErrorfrom either path, with a unified message.Docs
instanceofsubsection to the main Error Factory section and now also covers the constructor'sValidationErrorbehavior; JSDoc updated to match.Testing
ValidationError, async schemas throw in the constructor.pnpm type:checkand eslint are clean.