fix(nest): keep non-contract params and harden path param handling - #1818
Merged
Conversation
Contributor
|
Run failed. View the logs →
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
More templates
@orpc/ai-sdk
@orpc/arktype
@orpc/bun
@orpc/client
@orpc/cloudflare
@orpc/contract
@orpc/experimental-effect
@orpc/evlog
@orpc/hibernation
@orpc/json-schema
@orpc/nest
@orpc/next
@orpc/openapi
@orpc/opentelemetry
@orpc/pinia-colada
@orpc/pino
@orpc/publisher
@orpc/ratelimit
@orpc/server
@orpc/shared
@orpc/swr
@orpc/tanstack-query
@orpc/trpc
@orpc/valibot
@orpc/zod
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The NestJS adapter previously rebuilt request params from the contract's dynamic path params only, so anything else NestJS matched was dropped, and param names were read and written through the prototype chain. Params matched outside the contract path now reach the procedure input, and path params can no longer touch the prototype.
Fixes
@Controller(':tenant')) are no longer dropped, including when the contract path has no dynamic params at all.pathno longer collides with Express's wildcard key and disappears.__proto__become own properties on a null-prototype object instead of being silently lost or mutating the prototype.pathon Express,*on Fastify) and the raw wildcard key no longer leaks into input.Testing
/files/{path}route,__proto__injection, and a custom request parser without a wildcard param.implement.tssits at 100% statement and branch coverage.Chore
worker-configuration.d.tsfiles regenerated by wrangler (workerd version bump).