Skip to content

feat(standard-server)!: remove unused 'raw'#296

Closed
dinwwwh wants to merge 2 commits intomainfrom
feat/server/remove-raw-field-in-standard-lazy-request-response
Closed

feat(standard-server)!: remove unused 'raw'#296
dinwwwh wants to merge 2 commits intomainfrom
feat/server/remove-raw-field-in-standard-lazy-request-response

Conversation

@dinwwwh
Copy link
Copy Markdown
Member

@dinwwwh dinwwwh commented Mar 25, 2025

Summary by CodeRabbit

  • Refactor
    • Streamlined handling of network requests and responses by removing redundant intermediary data.
  • Tests
    • Updated multiple test scenarios to validate core request and response behaviors with a more concise data structure.
  • Chores
    • Cleaned up data interface definitions to reflect the updated processing logic.

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
orpc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2025 1:46am

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 25, 2025

Walkthrough

The pull request removes the raw property from various test cases and implementation functions across multiple packages. The changes simplify the structure of objects passed to methods like codec.decode, request handlers, and lazy conversion functions. Additionally, the interfaces for lazy requests and responses have been updated by eliminating the raw property. No public API or exported entity declarations were altered.

Changes

File(s) Change Summary
packages/client/…/rpc-link-codec.test.ts
packages/openapi/…/openapi-codec.test.ts
packages/server/…/rpc-codec.test.ts
Removed raw property from test inputs used in codec decoding tests.
packages/server/…/handler.test.ts (node & standard) Removed the raw line from request objects in handler tests.
packages/standard-server-fetch/…/(request.test.ts, response.test.ts, request.ts, response.ts) Eliminated the intermediate raw object and assertions checking raw from lazy request/response functions and their tests.
packages/standard-server-node/…/(request.test.ts, request.ts) Streamlined lazy request creation by removing the raw object and related test assertions.
packages/standard-server/…/types.ts Removed the raw property from the interface definitions for lazy requests and responses.
packages/zod/tsconfig.json Removed the compilerOptions section, specifically the rootDir option.

Possibly Related PRs

  • unnoq/orpc#269: The changes in the main PR and the retrieved PR both involve the removal of the raw property from test cases related to the codec.decode method, indicating a direct modification to the same input structure being tested.
  • unnoq/orpc#290: The changes in the main PR and the retrieved PR are related as both involve the removal of the raw property from test cases, specifically affecting how input objects are structured in tests for decoding methods.
  • unnoq/orpc#202: The changes in the main PR and the retrieved PR are related as both involve the removal of the raw property from input objects in test cases for codec functionality, specifically affecting how the decode method is tested in the rpc-link-codec and openapi-codec contexts.

Poem

I’m a bunny with hops so light,
Code paths clearer in the moonlit night.
Goodbye to raw clutter, clean and bright,
Small tests now sparkle with pure delight.
With whiskers twitching, I celebrate this sight! 🐇


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 600cf9f and 55a77f1.

📒 Files selected for processing (1)
  • packages/zod/tsconfig.json (0 hunks)
💤 Files with no reviewable changes (1)
  • packages/zod/tsconfig.json

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 25, 2025

Open in Stackblitz

More templates

@orpc/arktype

npm i https://pkg.pr.new/@orpc/arktype@296

@orpc/client

npm i https://pkg.pr.new/@orpc/client@296

@orpc/openapi

npm i https://pkg.pr.new/@orpc/openapi@296

@orpc/contract

npm i https://pkg.pr.new/@orpc/contract@296

@orpc/openapi-client

npm i https://pkg.pr.new/@orpc/openapi-client@296

@orpc/react-query

npm i https://pkg.pr.new/@orpc/react-query@296

@orpc/server

npm i https://pkg.pr.new/@orpc/server@296

@orpc/shared

npm i https://pkg.pr.new/@orpc/shared@296

@orpc/solid-query

npm i https://pkg.pr.new/@orpc/solid-query@296

@orpc/standard-server

npm i https://pkg.pr.new/@orpc/standard-server@296

@orpc/standard-server-fetch

npm i https://pkg.pr.new/@orpc/standard-server-fetch@296

@orpc/standard-server-node

npm i https://pkg.pr.new/@orpc/standard-server-node@296

@orpc/svelte-query

npm i https://pkg.pr.new/@orpc/svelte-query@296

@orpc/valibot

npm i https://pkg.pr.new/@orpc/valibot@296

@orpc/vue-colada

npm i https://pkg.pr.new/@orpc/vue-colada@296

@orpc/vue-query

npm i https://pkg.pr.new/@orpc/vue-query@296

@orpc/zod

npm i https://pkg.pr.new/@orpc/zod@296

commit: 55a77f1

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@dinwwwh
Copy link
Copy Markdown
Member Author

dinwwwh commented Mar 26, 2025

Don't know why ci failed, try later

@dinwwwh dinwwwh closed this Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant