feat(standard-server)!: remove unused raw

[dinwwwh]

Summary by CodeRabbit

• Refactor
  • Streamlined the handling of request and response data by removing redundant properties.
• Tests
  • Updated tests to align with the simplified data structures, ensuring consistent behavior.
• Chores
  • Refined configuration settings for improved compilation and project maintainability.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
orpc	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 26, 2025 1:55am

[coderabbitai]

Walkthrough

This pull request removes the use of the raw property (which contained an adapter field) across multiple test cases and implementations. The changes simplify the data structures used in codec, handler, and request/response modules. Test assertions and intermediate object constructions that previously relied on a raw object are now adjusted to directly use the corresponding parameters. There are no modifications to exported or public entities.

Changes

File(s)	Change Summary
packages/client/.../rpc-link-codec.test.ts, packages/openapi/.../openapi-codec.test.ts, packages/server/.../handler.test.ts (node & standard), packages/server/.../rpc-codec.test.ts	Removed the raw: { adapter: ... } property from multiple test cases, streamlining the inputs for the decode methods and request handling.
packages/standard-server-fetch/src/{request.test.ts, response.test.ts}	Deleted assertions checking the raw property in lazy request/response tests.
packages/standard-server-fetch/src/{request.ts, response.ts}, packages/standard-server-node/src/request.ts	Eliminated the intermediate raw object and directly utilized the request/response parameters.
packages/standard-server/src/types.ts	Removed the raw property from the StandardLazyRequest and StandardLazyResponse interfaces.
packages/zod/tsconfig.json	Removed the "rootDir": "src" property from the TypeScript compiler options.

Possibly related PRs

• unnoq/orpc#290: Involves similar removals of the raw property from test cases affecting codec behavior.
• unnoq/orpc#269: Focuses on removing the raw property in tests for different codecs, aligning with this PR’s simplification efforts.
• unnoq/orpc#202: Addresses the elimination of the raw: { adapter: 'unknown' } line in test cases for both RPCLinkCodec and StandardOpenAPICodec.

Poem

Hoppin’ through the code with cheer,
I’ve pruned the fluff that wasn’t clear.
The raw is gone, the tests are light,
Clean and simple, just right!
A bunny’s hop for code that’s tight!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 287d2e5 and 08b8e79.

📒 Files selected for processing (13)

• packages/client/src/adapters/standard/rpc-link-codec.test.ts (0 hunks)
• packages/openapi/src/adapters/standard/openapi-codec.test.ts (0 hunks)
• packages/server/src/adapters/node/handler.test.ts (0 hunks)
• packages/server/src/adapters/standard/handler.test.ts (0 hunks)
• packages/server/src/adapters/standard/rpc-codec.test.ts (0 hunks)
• packages/standard-server-fetch/src/request.test.ts (0 hunks)
• packages/standard-server-fetch/src/request.ts (1 hunks)
• packages/standard-server-fetch/src/response.test.ts (0 hunks)
• packages/standard-server-fetch/src/response.ts (1 hunks)
• packages/standard-server-node/src/request.test.ts (0 hunks)
• packages/standard-server-node/src/request.ts (1 hunks)
• packages/standard-server/src/types.ts (0 hunks)
• packages/zod/tsconfig.json (0 hunks)

💤 Files with no reviewable changes (10)

• packages/standard-server-fetch/src/request.test.ts
• packages/zod/tsconfig.json
• packages/openapi/src/adapters/standard/openapi-codec.test.ts
• packages/server/src/adapters/standard/handler.test.ts
• packages/standard-server-node/src/request.test.ts
• packages/server/src/adapters/node/handler.test.ts
• packages/standard-server-fetch/src/response.test.ts
• packages/client/src/adapters/standard/rpc-link-codec.test.ts
• packages/server/src/adapters/standard/rpc-codec.test.ts
• packages/standard-server/src/types.ts

🧰 Additional context used

🧬 Code Definitions (2)

packages/standard-server-fetch/src/request.ts (3)

packages/shared/src/function.ts (1)

• once (3-16)

packages/standard-server-fetch/src/body.ts (1)

• toStandardBody (7-53)

packages/standard-server-fetch/src/headers.ts (1)

• toStandardHeaders (7-21)

packages/standard-server-node/src/request.ts (2)

packages/shared/src/function.ts (1)

• once (3-16)

packages/standard-server-node/src/body.ts (1)

• toStandardBody (10-50)

🔇 Additional comments (5)

packages/standard-server-node/src/request.ts (1)

17-23: Simplification approved: Direct request handling improves code clarity.

The removal of the intermediate raw object simplifies the implementation while maintaining the same functionality. Now, the request object is directly passed to toStandardBody() rather than being wrapped in a raw object first. This change reduces unnecessary abstraction and aligns with the PR objective of removing unused raw properties throughout the codebase.

The use of the once() utility is maintained, which properly ensures that expensive body parsing operations are performed only once when accessed.

packages/standard-server-fetch/src/request.ts (2)

12-12: Simplification of body property initialization looks good.

The direct use of request parameter instead of accessing it through a raw object simplifies the code without changing functionality.

---

14-14: Simplified header access is an improvement.

Removing the unnecessary raw wrapper object streamlines the code structure and improves readability.

packages/standard-server-fetch/src/response.ts (2)

20-20: Simplified body initialization is a good change.

Directly calling toStandardBody(response) instead of going through a raw object makes the code cleaner and more maintainable.

---

23-23: Headers access simplification looks good.

Removing the intermediate raw object and directly accessing response.headers improves code clarity.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

[pkg-pr-new]

Open in Stackblitz

More templates

• @orpc/contract-first-playground
• @orpc/nextjs-playground
• @orpc/nuxt-playground
• @orpc/solid-start-playground
• @orpc/svelte-kit-playground

@orpc/arktype

npm i https://pkg.pr.new/@orpc/arktype@298

@orpc/client

npm i https://pkg.pr.new/@orpc/client@298

@orpc/contract

npm i https://pkg.pr.new/@orpc/contract@298

@orpc/openapi

npm i https://pkg.pr.new/@orpc/openapi@298

@orpc/openapi-client

npm i https://pkg.pr.new/@orpc/openapi-client@298

@orpc/server

npm i https://pkg.pr.new/@orpc/server@298

@orpc/react-query

npm i https://pkg.pr.new/@orpc/react-query@298

@orpc/shared

npm i https://pkg.pr.new/@orpc/shared@298

@orpc/solid-query

npm i https://pkg.pr.new/@orpc/solid-query@298

@orpc/standard-server

npm i https://pkg.pr.new/@orpc/standard-server@298

@orpc/standard-server-fetch

npm i https://pkg.pr.new/@orpc/standard-server-fetch@298

@orpc/standard-server-node

npm i https://pkg.pr.new/@orpc/standard-server-node@298

@orpc/svelte-query

npm i https://pkg.pr.new/@orpc/svelte-query@298

@orpc/valibot

npm i https://pkg.pr.new/@orpc/valibot@298

@orpc/vue-colada

npm i https://pkg.pr.new/@orpc/vue-colada@298

@orpc/vue-query

npm i https://pkg.pr.new/@orpc/vue-query@298

@orpc/zod

npm i https://pkg.pr.new/@orpc/zod@298

commit: 08b8e79