Skip to content

fix(server): cannot infer without reference issue#321

Merged
dinwwwh merged 1 commit intomainfrom
fix/server/cannot-infer-without-reference-issue-2
Apr 2, 2025
Merged

fix(server): cannot infer without reference issue#321
dinwwwh merged 1 commit intomainfrom
fix/server/cannot-infer-without-reference-issue-2

Conversation

@dinwwwh
Copy link
Copy Markdown
Member

@dinwwwh dinwwwh commented Apr 2, 2025

Summary by CodeRabbit

  • Chore
    • Enhanced our public API with additional type definitions, expanding integration options and strengthening the overall development experience without altering existing functionality.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
orpc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2025 7:09am

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 2, 2025

Walkthrough

The changes involve modifications to the exported types in the packages/server/src/index.ts file. The export from the @orpc/client module has been updated to add the ClientContext type alongside the existing HTTPMethod and HTTPPath types. Additionally, the @orpc/shared module now exports a new type called IntersectPick. These updates enhance the set of type definitions available for use across the application without affecting the runtime behavior.

Changes

File Path Change Summary
packages/.../index.ts - Updated export from @orpc/client to include ClientContext alongside HTTPMethod and HTTPPath.
- Added new export IntersectPick from @orpc/shared.

Possibly related PRs

  • unnoq/orpc#315: Modifies exported types from the @orpc/client module, relating to the types HTTPMethod and HTTPPath.
  • unnoq/orpc#291: Involves removal of the ClientContext type from the ClientRetryPlugin, indicating a change in how ClientContext is utilized.

Poem

I'm a bunny, hopping through the code,
With types so crisp and neatly bestowed.
New exports spring like buds in bloom,
Making our project bright, banishing gloom.
ASCII hops to a future so bold — 🐇🎉!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f47352c and 3f47e4f.

📒 Files selected for processing (1)
  • packages/server/src/index.ts (2 hunks)
🔇 Additional comments (2)
packages/server/src/index.ts (2)

24-24: Addition of ClientContext export enhances API completeness

Adding the ClientContext type to the exports makes the API more consistent by exposing a related type that was previously missing. This change will help consumers of this package properly type their client implementations without needing to directly import from @orpc/client.


41-41: Addition of IntersectPick type export improves type utility

The new export of IntersectPick from @orpc/shared makes this utility type available to consumers of the server package. Based on its name, this likely provides a way to combine TypeScript's Pick functionality with intersection types, which would be useful for complex type transformations. This addition improves the package's type utility without affecting runtime behavior.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 2, 2025

More templates

@orpc/arktype

npm i https://pkg.pr.new/@orpc/arktype@321

@orpc/client

npm i https://pkg.pr.new/@orpc/client@321

@orpc/openapi

npm i https://pkg.pr.new/@orpc/openapi@321

@orpc/contract

npm i https://pkg.pr.new/@orpc/contract@321

@orpc/openapi-client

npm i https://pkg.pr.new/@orpc/openapi-client@321

@orpc/react

npm i https://pkg.pr.new/@orpc/react@321

@orpc/react-query

npm i https://pkg.pr.new/@orpc/react-query@321

@orpc/server

npm i https://pkg.pr.new/@orpc/server@321

@orpc/shared

npm i https://pkg.pr.new/@orpc/shared@321

@orpc/solid-query

npm i https://pkg.pr.new/@orpc/solid-query@321

@orpc/standard-server

npm i https://pkg.pr.new/@orpc/standard-server@321

@orpc/standard-server-fetch

npm i https://pkg.pr.new/@orpc/standard-server-fetch@321

@orpc/standard-server-node

npm i https://pkg.pr.new/@orpc/standard-server-node@321

@orpc/svelte-query

npm i https://pkg.pr.new/@orpc/svelte-query@321

@orpc/valibot

npm i https://pkg.pr.new/@orpc/valibot@321

@orpc/vue-colada

npm i https://pkg.pr.new/@orpc/vue-colada@321

@orpc/vue-query

npm i https://pkg.pr.new/@orpc/vue-query@321

@orpc/zod

npm i https://pkg.pr.new/@orpc/zod@321

commit: 3f47e4f

@dinwwwh dinwwwh merged commit bdd211a into main Apr 2, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant