docs: remove undefined createMiddleware in Hono integration#394
docs: remove undefined createMiddleware in Hono integration#394dinwwwh merged 1 commit intomiddleapi:mainfrom
createMiddleware in Hono integration#394Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe change updates the integration documentation for the Hono application. The modification involves removing the Changes
Poem
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/content/docs/integrations/hono.md (1)
16-19: Optional: Clarify therouterReferenceThe code snippet instantiates
RPCHandlerwith arouter(i.e.,new RPCHandler(router)) but does not show its definition. To help users understand thatrouterrepresents an existing or user-defined routing mechanism, consider adding a brief inline comment or note indicating thatroutershould be defined or imported for a complete setup.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/content/docs/integrations/hono.md(1 hunks)
🔇 Additional comments (1)
apps/content/docs/integrations/hono.md (1)
13-14: Refined Import Statement Improves ClarityThe revised import now only includes
RPCHandlerfrom@orpc/server/fetch, effectively removing the unused and undefinedcreateMiddlewarefunction. This aligns perfectly with the PR objectives and enhances the clarity of the documentation by reducing potential confusion.
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
More templates
@orpc/arktype
@orpc/client
@orpc/contract
@orpc/openapi
@orpc/openapi-client
@orpc/react-query
@orpc/react
@orpc/server
@orpc/shared
@orpc/solid-query
@orpc/standard-server
@orpc/standard-server-fetch
@orpc/standard-server-node
@orpc/svelte-query
@orpc/valibot
@orpc/vue-colada
@orpc/vue-query
@orpc/zod
commit: |
createHandler in Hono integration…createMiddleware in Hono integration
Removes the unused (and also undefined)
createMiddlewarefunction from the Hono integration docs.Summary by CodeRabbit