Skip to content

fix(server): prevent reference issues in ResponseHeadersPlugin #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dinwwwh merged 1 commit into from
Jun 26, 2025
Merged

fix(server): prevent reference issues in ResponseHeadersPlugin #693

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions packages/server/src/plugins/response-headers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import type { StandardHandlerOptions, StandardHandlerPlugin } from '../adapters/standard'
import { clone } from '@orpc/shared'

export interface ResponseHeadersPluginContext {
resHeaders?: Headers
Expand Down Expand Up @@ -29,7 +30,7 @@ export class ResponseHeadersPlugin<T extends ResponseHeadersPluginContext> imple
return result
}

const responseHeaders = result.response.headers
const responseHeaders = clone(result.response.headers)
Comment thread
dinwwwh marked this conversation as resolved.

for (const [key, value] of resHeaders) {
if (Array.isArray(responseHeaders[key])) {
Expand All @@ -43,7 +44,13 @@ export class ResponseHeadersPlugin<T extends ResponseHeadersPluginContext> imple
}
}

return result
return {
...result,
response: {
...result.response,
headers: responseHeaders,
},
}
})
}
}