rename enums/typedefs to from "MIDI" to "MIDI_1" to support building alongside current tinyusb with "midi.h"#9
Merged
AmeNote-Michael merged 1 commit intomidi2-dev:mainfrom Mar 10, 2026
Conversation
…alongside current tinyusb with "midi.h"
Contributor
|
Thank you for the input. Sorry for delay in seeing this, I did not get notification for some reason. I had figured that an integrator would be doing one or other and not try to include both at same time. But if transitioning from old midi.h to ump.h they would want to keep their use of compiler defines, not needing to replace all in their code. Please help explain why you would want to use midi.h and ump.h at same time? |
Contributor
|
@fdetro @starfishmod i am starting to realize that maybe we should be doing this change - I would love your guys opinions. |
This was referenced Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
while bringing the project alongside tinyusb and building in stm32CubeIDE. I had redefinition conflicts from the current midi.h in tinyusb.
I'm adding this PR in case its a usefull to facilitate easier transition.