Skip to content

Prune#1

Merged
midwire merged 3 commits intomidwire:legacyfrom
firien:prune
Apr 20, 2018
Merged

Prune#1
midwire merged 3 commits intomidwire:legacyfrom
firien:prune

Conversation

@firien
Copy link
Copy Markdown

@firien firien commented Jan 3, 2018

  • removed here_with_pipe calls
  • apparently writing sqlite in memory and then dumping to disk is much faster

feel free to close/reject

Comment thread Gemfile
source 'http://rubygems.org'
source 'https://rubygems.org'

gem 'midwire_common'
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was midwire_common removed? I believe it contains some rake tasks for the release process.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eh - I always like as few dependencies as possible. On the master branch bundle exec rake --tasks only lists those found in lib/tasks/data.rake

But I can include it again if you wish.

@cmckni3
Copy link
Copy Markdown
Collaborator

cmckni3 commented Jan 4, 2018

This is really neat. TIL: creating an in-memory SQLite database.

@midwire midwire changed the base branch from master to legacy April 20, 2018 22:17
@midwire
Copy link
Copy Markdown
Owner

midwire commented Apr 20, 2018

@firien thanks for the PR. I apologize for the lateness of my attention. I had notifications turned off for this account and did not see the PR until just today. I am merging this into a new legacy branch as we are starting to re-writing this project, but the in-memory tables are probably something we will want to use in the rewrite.

@midwire midwire merged commit b428936 into midwire:legacy Apr 20, 2018
@midwire midwire mentioned this pull request Apr 21, 2018
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants