Skip to content

Support pull_request in branch handling#7

Open
cmyers-mieweb wants to merge 3 commits intomainfrom
cmyers_issue5
Open

Support pull_request in branch handling#7
cmyers-mieweb wants to merge 3 commits intomainfrom
cmyers_issue5

Conversation

@cmyers-mieweb
Copy link
Collaborator

Issue: #5

Add handling for pull_request events: expose GITHUB_HEAD_REF and use it to set TARGET_BRANCH for PRs. Update workflow conditionals so the Create/Locate Container step runs for pull_request events (except when action is closed), and treat pull_request closed as a branch deletion for the Container Deletion step. This enables the action to properly create and clean up containers for pull request workflows. Also is conjunction with mieweb/opensource-server#196

Add handling for pull_request events: expose GITHUB_HEAD_REF and use it to set TARGET_BRANCH for PRs. Update workflow conditionals so the Create/Locate Container step runs for pull_request events (except when action is closed), and treat pull_request closed as a branch deletion for the Container Deletion step. This enables the action to properly create and clean up containers for pull request workflows.
Copy link
Collaborator

@runleveldev runleveldev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants