Merged
Conversation
…nstalling it on the container if the user chose to install a specific version
Implement a JSON server that filters and returns specific host keys from a JSON file.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces miscellaneous improvements to the cluster infrastructure, focusing on runtime version specification, path normalization fixes, and documentation updates.
- Updates Proxmox Launchpad to support version specification for runtime environments (e.g.,
python@3.8.9ornodejs@18) - Fixes path formatting issues that caused errors in environment variable updates and service startup
- Adds the landing page as a submodule and updates documentation references
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| nginx reverse proxy/port-map-server.js | New JSON server for filtering and serving host information to the landing page |
| mie-opensource-landing | Submodule addition for the landing page source code |
| container creation/start_services.sh | Path normalization fixes for service startup commands |
| container creation/python_runtime_install.sh | New script for installing specific Python runtime versions |
| container creation/node_runtime_install.sh | New script for installing specific Node.js runtime versions |
| container creation/deployOnStart.sh | Runtime version installation logic and path normalization improvements |
| container creation/create-container.sh | Support for self-hosted runner parameter |
| ci-cd automation/update-container.sh | Environment variable handling improvements and path fixes |
| ci-cd automation/setup-runner.sh | Cleanup of unnecessary SSH key operations |
| ci-cd automation/check-container-exists.sh | Container ID validation before execution |
| ci-cd automation/Proxmox-Launchpad | Submodule update |
| README.md | Documentation updates with new landing page references |
| .gitmodules | Submodule configuration for landing page |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
|
@maxklema is this in prod? Should this be merged? |
Contributor
Author
horner
approved these changes
Sep 5, 2025
Member
horner
left a comment
horner
left a comment
There was a problem hiding this comment.
I'm getting cleaned up for transfer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A collection of Misc. Changes to the cluster:
python@3.8.9ornodejs@18.