-
Notifications
You must be signed in to change notification settings - Fork 3
Reduce external dependencies and improve RESTfulness of create-a-container #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cmyers-mieweb
merged 9 commits into
main
from
50-create-a-container-use-extensionless-urls
Oct 20, 2025
Merged
Reduce external dependencies and improve RESTfulness of create-a-container #62
cmyers-mieweb
merged 9 commits into
main
from
50-create-a-container-use-extensionless-urls
Oct 20, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b071fda to
eb98b49
Compare
This was referenced Oct 14, 2025
…redirect parameter
ef7a990 to
0b35ea0
Compare
cmyers-mieweb
approved these changes
Oct 20, 2025
Collaborator
cmyers-mieweb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, going to perform test against create-a-container prod to deploy and test as a prelude to the new opensource node.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #50, #53, #58, #60
As is, these changes are hard to test due to the dependencies on the create-a-container server environment, but I did my best to replicate it at https://create-a-container-dev.opensource.mieweb.org/ for demonstration. The UI is fully functional but I did not replicate all scripts necessary to actually create a container. Functionality should be similar enough to avoid breaking via the UI however.