feat(condensed): add condensed view support for Progress, Skeleton, and Spinner#158
Merged
garrity-miepub merged 4 commits intomainfrom Apr 1, 2026
Merged
Conversation
- Add 8 data-slots: progress, progress-label-row, progress-label, progress-value, progress-track, progress-fill, circular-progress, circular-progress-value - All bar track sizes collapse to sm (h-1) in condensed mode - All circular sizes collapse to sm (2rem) in condensed mode - Smaller label/value text (0.625rem)
There was a problem hiding this comment.
Pull request overview
Adds condensed-density support for the Progress component family by introducing data-slot hooks and new condensed CSS overrides so Progress bars and CircularProgress render more compactly in body.condensed mode.
Changes:
- Added
data-slotattributes to Progress and CircularProgress DOM nodes to enable condensed-mode targeting. - Added condensed CSS overrides for Progress label/value typography and bar track height.
- Added condensed CSS overrides to collapse CircularProgress container sizes down to the small (2rem) footprint.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/styles/condensed-view.css | Adds condensed-mode overrides for Progress bar/circular sizing and label/value typography. |
| src/components/Progress/Progress.tsx | Adds data-slot hooks for Progress/CircularProgress sub-elements for condensed-mode styling. |
Comments suppressed due to low confidence (1)
src/components/Progress/Progress.tsx:253
- Condensed CSS collapses
[data-slot='circular-progress']container to 2rem for md/lg/xl, but the inner<svg>still uses fixedwidth/heightbased onsizeMap(48/64/96). That will likely overflow the shrunken container and defeat the condensed sizing. Consider making the SVG size derive from the container (e.g., width/height 100% + aviewBox), or add a dedicated slot/class so condensed CSS can also constrain the SVG dimensions.
return (
<div
data-slot="circular-progress"
role="progressbar"
aria-valuenow={indeterminate ? undefined : value}
aria-valuemin={0}
aria-valuemax={max}
aria-label="Progress"
className={cn(circularProgressVariants({ size }), className)}
>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add 4 data-slots: skeleton, skeleton-text, skeleton-card, skeleton-table - Smaller placeholder heights for text/title/button/card variants - Tighter line gaps for SkeletonText - Compact padding and gaps for SkeletonCard and SkeletonTable
Deploying ui with
|
| Latest commit: |
d0030ed
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a24f3e2a.ui-6d0.pages.dev |
| Branch Preview URL: | https://feature-condensed-view-loade.ui-6d0.pages.dev |
- Add 5 data-slots: spinner, spinner-with-label, spinner-label, full-page-spinner - All spinner sizes collapse to sm (1rem) in condensed mode - Tighter gaps and smaller label text for SpinnerWithLabel/FullPageSpinner
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…is() selectors - Fix circular progress SVG overflow with overflow:hidden and svg 100% sizing - Replace gap with margin overrides for space-y-* containers (SkeletonText/Card/Table) - Consolidate progress track and circular selectors using :is() - Remove SkeletonTable redundant gap rule
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Condensed view support for Progress, Skeleton, and Spinner components
Progress
Skeleton
Spinner
Review fixes
:is()