Skip to content

feat: add icon selector dropdowns to Button stories and stricter icon types#20

Merged
garrity-miepub merged 1 commit intomainfrom
feature/button-updates-fix
Jan 28, 2026
Merged

feat: add icon selector dropdowns to Button stories and stricter icon types#20
garrity-miepub merged 1 commit intomainfrom
feature/button-updates-fix

Conversation

@garrity-miepub
Copy link
Copy Markdown
Contributor

Button.stories.tsx:

  • Add Lucide icon imports (~50 icons)
  • Create iconRegistry for Storybook dropdown controls
  • Add leftIcon/rightIcon argTypes with icon selector dropdowns
  • Replace inline SVG with Lucide components
  • Add WithRightIcon and WithBothIcons stories

Button.tsx:

  • Change leftIcon/rightIcon type from ReactNode to ReactElement | null
  • Add React.isValidElement() checks for icon rendering
  • Simplify aria-busy attribute

Improves DX with interactive icon selection in Storybook controls.

button-updates.mov

@garrity-miepub garrity-miepub marked this pull request as ready for review January 28, 2026 03:16
@garrity-miepub garrity-miepub merged commit b21d9cb into main Jan 28, 2026
3 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant