Skip to content

feat(AudioPlayer): enhance Storybook controls with all component props#44

Merged
garrity-miepub merged 2 commits intomainfrom
feature/audio-player-update
Jan 31, 2026
Merged

feat(AudioPlayer): enhance Storybook controls with all component props#44
garrity-miepub merged 2 commits intomainfrom
feature/audio-player-update

Conversation

@garrity-miepub
Copy link
Copy Markdown
Contributor

  • Add comprehensive argTypes for all AudioPlayer props
  • Add conditional waveform controls (waveColor, progressColor, waveformHeight)
  • Set sensible default values for demo
  • Update Default story to use args for interactive controls
  • Add component description to docs
audio-player-update.mov

- Add comprehensive argTypes for all AudioPlayer props
- Add conditional waveform controls (waveColor, progressColor, waveformHeight)
- Set sensible default values for demo
- Update Default story to use args for interactive controls
- Add component description to docs
Copilot AI review requested due to automatic review settings January 31, 2026 01:17
@garrity-miepub garrity-miepub marked this pull request as ready for review January 31, 2026 01:17
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request enhances the Storybook documentation for the AudioPlayer component by adding comprehensive interactive controls and improving the documentation experience. The changes make it easier for developers to explore and understand the AudioPlayer component's various configuration options.

Changes:

  • Added comprehensive argTypes for all user-configurable props including variant, size, title, and display controls
  • Added conditional waveform-specific controls (waveColor, progressColor, waveformHeight) that only appear when the waveform variant is selected
  • Updated the Default story to use args for interactive controls instead of hardcoded props
  • Added component description to the documentation page

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- showDuration: false → true (matches component default)
- waveformHeight: 80 → 64 (matches component default)
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Jan 31, 2026

Deploying ui with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9b04b7d
Status: ✅  Deploy successful!
Preview URL: https://b700bcdf.ui-6d0.pages.dev
Branch Preview URL: https://feature-audio-player-update.ui-6d0.pages.dev

View logs

@garrity-miepub garrity-miepub merged commit e8c383d into main Jan 31, 2026
10 checks passed
@garrity-miepub garrity-miepub deleted the feature/audio-player-update branch January 31, 2026 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants