Remove debug dnf module list from konflux.Dockerfile#16
Merged
Conversation
MTA 8.2 rebases the runtime stage onto base-rhel9 (UBI minimal), which uses microdnf and does not support `dnf module list`. The line was debug-only and breaks Konflux PLR build-images on the minimal base. rh-pre-commit.version: 2.4.0 rh-pre-commit.check-secrets: ENABLED
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe Dockerfile's build artifacts stage now explicitly copies an overridden ChangesDockerfile Build Adjustments
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RUN dnf module listfromkonflux.Dockerfileruntime stageMotivation
MTA 8.2 rebases the runtime stage onto
base-rhel9(UBI minimal / microdnf). microdnf does not support thednf module listsubcommand, so Konflux PLRbuild-imagesfails:The line was debug-only and is not needed for production builds. Confirmed in Jenkins layered-products #8163 (
mta-8-2-mta-jdtls-server-base-xl7nr).Related: openshift-eng/ocp-build-data#11596 (base-rhel9 migration), #15 (generic cachi2 artifact paths).
Test plan
mta-jdtls-server-base,mta-java-external-provider,mta-clion mta-8.2Summary by CodeRabbit