Skip to content

Remove debug dnf module list from konflux.Dockerfile#16

Merged
fbladilo merged 1 commit into
migtools:mainfrom
fbladilo:fix-konflux-dnf-module-list
Jul 2, 2026
Merged

Remove debug dnf module list from konflux.Dockerfile#16
fbladilo merged 1 commit into
migtools:mainfrom
fbladilo:fix-konflux-dnf-module-list

Conversation

@fbladilo

@fbladilo fbladilo commented Jul 2, 2026

Copy link
Copy Markdown

Summary

  • Remove RUN dnf module list from konflux.Dockerfile runtime stage

Motivation

MTA 8.2 rebases the runtime stage onto base-rhel9 (UBI minimal / microdnf). microdnf does not support the dnf module list subcommand, so Konflux PLR build-images fails:

error: Unknown subcommand: 'list'
Error: building at STEP "RUN . /cachi2/cachi2.env &&     dnf module list": exit status 1

The line was debug-only and is not needed for production builds. Confirmed in Jenkins layered-products #8163 (mta-8-2-mta-jdtls-server-base-xl7nr).

Related: openshift-eng/ocp-build-data#11596 (base-rhel9 migration), #15 (generic cachi2 artifact paths).

Test plan

  • Merge and wait for openshift-priv forwarding
  • Re-run layered-products for mta-jdtls-server-base, mta-java-external-provider, mta-cli on mta-8.2

Summary by CodeRabbit

  • Chores
    • Updated the container build to copy the JDTLS Python runtime into the final image more directly.
    • Simplified image setup by removing an unnecessary package-listing step during installation.

MTA 8.2 rebases the runtime stage onto base-rhel9 (UBI minimal), which
uses microdnf and does not support `dnf module list`. The line was
debug-only and breaks Konflux PLR build-images on the minimal base.

rh-pre-commit.version: 2.4.0
rh-pre-commit.check-secrets: ENABLED
@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ae857247-47db-47c7-b042-27faa73ccd43

📥 Commits

Reviewing files that changed from the base of the PR and between 7d84179 and ea55c9e.

📒 Files selected for processing (1)
  • konflux.Dockerfile
💤 Files with no reviewable changes (1)
  • konflux.Dockerfile

📝 Walkthrough

Walkthrough

The Dockerfile's build artifacts stage now explicitly copies an overridden jdtls.py file into the JDTLS runtime bin directory. Additionally, the dnf module list command was removed from the final stage prior to package installation.

Changes

Dockerfile Build Adjustments

Layer / File(s) Summary
Copy jdtls.py override and remove dnf module list
konflux.Dockerfile
The artifacts stage now copies jdtls.py from the override directory into /jdtls/bin/jdtls.py, and the final stage no longer runs dnf module list before the package installation step.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely describes the main change: removing the debug dnf module list command from konflux.Dockerfile.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@fbladilo fbladilo merged commit 9fde0c7 into migtools:main Jul 2, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant