fix: don't try to process directories (#145)#171
Merged
simonua merged 2 commits intomiickel:masterfrom Apr 29, 2019
Merged
Conversation
Collaborator
|
Hi @the-ress, thank you very much for your PR! I appreciate the contribution. I am a little backed up with work right now, but I will try to get to reviewing this in the next week or two. |
dmellstrom
approved these changes
Apr 25, 2019
Contributor
dmellstrom
left a comment
dmellstrom
left a comment
There was a problem hiding this comment.
Looks good to me. Fixed all instances of #145 that I was able to replicate.
Collaborator
|
@the-ress, LGTM, too. Thank you very much for addressing this! |
Collaborator
|
@the-ress & @dmellstrom, thank you two very much. I just published 2.2.7 with this fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#145 is caused by trying to read the contents of a directory (at least in my case).
Here's a fix and a test.