Add type hints#246
Closed
inverse wants to merge 3 commits intomike-grant:masterfrom
inverse:add-type-hints
Closed
Conversation
Contributor
inverse
commented
Jul 26, 2022
inverse
commented
- Add typehints
- Make some methods static that don't require self
- Remove redundant inheritance from object
Contributor
Author
|
@mike-grant able to take a look at this? Need help maintaining this repo? |
Seems he doesn't have any more time to work on this. @mike-grant, can you be so kind to just confirm my hypothesis ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.