More classifiers#4
Merged
mike-ward merged 1 commit intomike-ward:masterfrom Apr 8, 2022
Merged
Conversation
Add classifiers to match logs produced by SimpleConsoleFormatter https://github.com/dotnet/runtime/blob/6a889d23/src/libraries/Microsoft.Extensions.Logging.Console/src/SimpleConsoleFormatter.cs#L142-L154
Contributor
Author
|
@mike-ward thanks for merging. When do you think you may publicly release this? |
Owner
|
Gosh, I thought I did. |
Contributor
Author
|
Hah, I think I totally missed it. Sorry :) |
Owner
|
No worries. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add classifiers to match logs produced by SimpleConsoleFormatter https://github.com/dotnet/runtime/blob/6a889d23/src/libraries/Microsoft.Extensions.Logging.Console/src/SimpleConsoleFormatter.cs#L142-L154
The Windows Forms designer in Visual Studio emits diagnostics logs, and I'm making sure these logs are correctly categorised (and prefixed). The prefix strategy is the same as employed by
SimpleConsoleFormatter.This will help developers who build Windows Forms .NET applications (and obviously use your wonderful extension) to read the diagnostics output.
Before:
After:
I've tested it manually by applying the changes in the installed extension, and then applying the changes to the code.